From patchwork Fri Sep 11 14:00:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: richard kennedy X-Patchwork-Id: 46856 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8BE0XLC022972 for ; Fri, 11 Sep 2009 14:00:33 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbZIKOA3 (ORCPT ); Fri, 11 Sep 2009 10:00:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751627AbZIKOA3 (ORCPT ); Fri, 11 Sep 2009 10:00:29 -0400 Received: from lon1-post-1.mail.demon.net ([195.173.77.148]:62865 "EHLO lon1-post-1.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbZIKOA2 (ORCPT ); Fri, 11 Sep 2009 10:00:28 -0400 Received: from rsk.demon.co.uk ([80.176.90.227] helo=[192.168.0.3]) by lon1-post-1.mail.demon.net with esmtp (Exim 4.69) id 1Mm6fu-00069P-Z8; Fri, 11 Sep 2009 14:00:30 +0000 Subject: Re: UWB Kconfig: cannot set UWB to N in gconfig From: Richard Kennedy To: Randy Dunlap Cc: David Vrabel , Roman Zippel , linux-usb , linux-kbuild , lkml In-Reply-To: <20090910090806.e8db2300.randy.dunlap@oracle.com> References: <1252577154.2340.12.camel@castor> <20090910090806.e8db2300.randy.dunlap@oracle.com> Date: Fri, 11 Sep 2009 15:00:30 +0100 Message-Id: <1252677630.2282.11.camel@castor> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Thu, 2009-09-10 at 09:08 -0700, Randy Dunlap wrote: > On Thu, 10 Sep 2009 11:05:54 +0100 Richard Kennedy wrote: > > > I sometimes use 'make gconfig' and I noticed that I cannot disable the > > UWB option -- it just won't let me set it to N. > > Not specific to 'gconfig'. > > > AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it > > on. > > Yes. > > > applying this patch fixes the issue but I'm not sure if this is the > > right way to go about it. > > > > any thoughts? > > UWB can be disabled by disabling both of these options that are several > entries below it in the same menu: > > USB_WHCI_HCD and USB_HWA_HCD > > and then returning to UWB and disabling it. > > Should users have to figure that out? no. > thanks, although it's not easy to figure out how to disable this in gconfig. USB_WHCI_HCD & USB_HWA_HCD end up under a different menu (drivers/usb/host). If you don't know that they exist, all you see is the options under UWB set to M and gconfig doesn't let you turn them off. Here's another version of the patch that changes them all to 'depends on'. This lets gconfig do the right thing :) regards Richard --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 1a920c7..5b6924b 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -347,8 +347,8 @@ config USB_WHCI_HCD tristate "Wireless USB Host Controller Interface (WHCI) driver (EXPERIMENTAL)" depends on EXPERIMENTAL depends on PCI && USB - select USB_WUSB - select UWB_WHCI + depends on USB_WUSB + depends on UWB_WHCI help A driver for PCI-based Wireless USB Host Controllers that are compliant with the WHCI specification. @@ -360,8 +360,8 @@ config USB_HWA_HCD tristate "Host Wire Adapter (HWA) driver (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select USB_WUSB - select UWB_HWA + depends on USB_WUSB + depends on UWB_HWA help This driver enables you to connect Wireless USB devices to your system using a Host Wire Adaptor USB dongle. This is an diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig index eb09a0a..8209da9 100644 --- a/drivers/usb/wusbcore/Kconfig +++ b/drivers/usb/wusbcore/Kconfig @@ -5,7 +5,7 @@ config USB_WUSB tristate "Enable Wireless USB extensions (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select UWB + depends on UWB select CRYPTO select CRYPTO_BLKCIPHER select CRYPTO_CBC