| Message ID | 1302015561-21047-10-git-send-email-mmarek@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/05/2011 07:58 AM, Michal Marek wrote: > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: x86@kernel.org > Signed-off-by: Michal Marek <mmarek@suse.cz> > --- > arch/x86/boot/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile > index f7cb086..7a70c60 100644 > --- a/arch/x86/boot/Makefile > +++ b/arch/x86/boot/Makefile > @@ -13,7 +13,7 @@ > # This can be either FLOPPY, CURRENT, /dev/xxxx or empty, in which case > # the default of FLOPPY is used by 'build'. > > -ROOT_DEV := CURRENT > +ROOT_DEV ?= CURRENT > > # If you want to preset the SVGA mode, uncomment the next line and > # set SVGA_MODE to whatever number you want. Is this a good thing? As far as I understand ?= it may mean picking something up from the outside environment. Since ROOT_DEV has been obsolete for 15 years or more, this would seem to be a needless new error mode. -hpa
On 5.4.2011 17:30, H. Peter Anvin wrote: >> --- a/arch/x86/boot/Makefile >> +++ b/arch/x86/boot/Makefile >> @@ -13,7 +13,7 @@ >> # This can be either FLOPPY, CURRENT, /dev/xxxx or empty, in which case >> # the default of FLOPPY is used by 'build'. >> >> -ROOT_DEV := CURRENT >> +ROOT_DEV ?= CURRENT >> >> # If you want to preset the SVGA mode, uncomment the next line and >> # set SVGA_MODE to whatever number you want. > > Is this a good thing? As far as I understand ?= it may mean picking > something up from the outside environment. > > Since ROOT_DEV has been obsolete for 15 years or more, this would seem > to be a needless new error mode. So can we just set the default root device to (0, 0)? Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile index f7cb086..7a70c60 100644 --- a/arch/x86/boot/Makefile +++ b/arch/x86/boot/Makefile @@ -13,7 +13,7 @@ # This can be either FLOPPY, CURRENT, /dev/xxxx or empty, in which case # the default of FLOPPY is used by 'build'. -ROOT_DEV := CURRENT +ROOT_DEV ?= CURRENT # If you want to preset the SVGA mode, uncomment the next line and # set SVGA_MODE to whatever number you want.
Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/x86/boot/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)