| Message ID | 1302015561-21047-19-git-send-email-mmarek@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dne 5.4.2011 16:59, Michal Marek napsal(a): > The kernel already prints its build timestamp during boot, no need to > repeat it in random drivers and produce different object files each > time. > > Cc: "David S. Miller" <davem@davemloft.net> > Cc: netdev@vger.kernel.org > Signed-off-by: Michal Marek <mmarek@suse.cz> > --- > drivers/net/wan/pc300_drv.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) I don't see the patch in today's linux-next. Does anyone object against me applying it to kbuild-2.6.git? Thanks, Michal > diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c > index f875cfa..80ae503 100644 > --- a/drivers/net/wan/pc300_drv.c > +++ b/drivers/net/wan/pc300_drv.c > @@ -3242,8 +3242,7 @@ static inline void show_version(void) > rcsdate++; > tmp = strrchr(rcsdate, ' '); > *tmp = '\0'; > - printk(KERN_INFO "Cyclades-PC300 driver %s %s (built %s %s)\n", > - rcsvers, rcsdate, __DATE__, __TIME__); > + printk(KERN_INFO "Cyclades-PC300 driver %s %s\n", rcsvers, rcsdate); > } /* show_version */ > > static const struct net_device_ops cpc_netdev_ops = { -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Michal Marek <mmarek@suse.cz> Date: Wed, 25 May 2011 22:43:09 +0200 > Dne 5.4.2011 16:59, Michal Marek napsal(a): >> The kernel already prints its build timestamp during boot, no need to >> repeat it in random drivers and produce different object files each >> time. >> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: netdev@vger.kernel.org >> Signed-off-by: Michal Marek <mmarek@suse.cz> >> --- >> drivers/net/wan/pc300_drv.c | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) > > I don't see the patch in today's linux-next. Does anyone object against > me applying it to kbuild-2.6.git? Just do it :-) Acked-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c index f875cfa..80ae503 100644 --- a/drivers/net/wan/pc300_drv.c +++ b/drivers/net/wan/pc300_drv.c @@ -3242,8 +3242,7 @@ static inline void show_version(void) rcsdate++; tmp = strrchr(rcsdate, ' '); *tmp = '\0'; - printk(KERN_INFO "Cyclades-PC300 driver %s %s (built %s %s)\n", - rcsvers, rcsdate, __DATE__, __TIME__); + printk(KERN_INFO "Cyclades-PC300 driver %s %s\n", rcsvers, rcsdate); } /* show_version */ static const struct net_device_ops cpc_netdev_ops = {
The kernel already prints its build timestamp during boot, no need to repeat it in random drivers and produce different object files each time. Cc: "David S. Miller" <davem@davemloft.net> Cc: netdev@vger.kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- drivers/net/wan/pc300_drv.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)