diff mbox

[1/2] gconfig: enable rules hint for main treeviews

Message ID 1305808621.11775.3.camel@monotop (mailing list archive)
State New, archived
Headers show

Commit Message

Eduardo Silva May 19, 2011, 12:37 p.m. UTC
Due to the large amount of rows in the treeviews, is difficult to
match columns with rows, setting the rules hint to 'true' allows the
treeview to alternate background colors in the rows making the data
more readable.

Signed-off-by: Eduardo Silva <edsiper@gmail.com>
---
 scripts/kconfig/gconf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Randy Dunlap May 19, 2011, 4:13 p.m. UTC | #1
On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:

> Due to the large amount of rows in the treeviews, is difficult to
> match columns with rows, setting the rules hint to 'true' allows the
> treeview to alternate background colors in the rows making the data
> more readable.
> 
> Signed-off-by: Eduardo Silva <edsiper@gmail.com>

Tested-by: Randy Dunlap <randy.dunlap@oracle.com>

Nice.  Thanks.


> ---
>  scripts/kconfig/gconf.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 4558961..0c8db7d 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -253,7 +253,7 @@ void init_left_tree(void)
>  
>  	gtk_tree_view_set_model(view, model1);
>  	gtk_tree_view_set_headers_visible(view, TRUE);
> -	gtk_tree_view_set_rules_hint(view, FALSE);
> +	gtk_tree_view_set_rules_hint(view, TRUE);
>  
>  	column = gtk_tree_view_column_new();
>  	gtk_tree_view_append_column(view, column);
> @@ -298,7 +298,7 @@ void init_right_tree(void)
>  
>  	gtk_tree_view_set_model(view, model2);
>  	gtk_tree_view_set_headers_visible(view, TRUE);
> -	gtk_tree_view_set_rules_hint(view, FALSE);
> +	gtk_tree_view_set_rules_hint(view, TRUE);
>  
>  	column = gtk_tree_view_column_new();
>  	gtk_tree_view_append_column(view, column);
> -- 

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Marek May 24, 2011, 1:55 p.m. UTC | #2
On Thu, May 19, 2011 at 09:13:09AM -0700, Randy Dunlap wrote:
> On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:
> 
> > Due to the large amount of rows in the treeviews, is difficult to
> > match columns with rows, setting the rules hint to 'true' allows the
> > treeview to alternate background colors in the rows making the data
> > more readable.
> > 
> > Signed-off-by: Eduardo Silva <edsiper@gmail.com>
> 
> Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Nice.  Thanks.

Applied, thanks.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 4558961..0c8db7d 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -253,7 +253,7 @@  void init_left_tree(void)
 
 	gtk_tree_view_set_model(view, model1);
 	gtk_tree_view_set_headers_visible(view, TRUE);
-	gtk_tree_view_set_rules_hint(view, FALSE);
+	gtk_tree_view_set_rules_hint(view, TRUE);
 
 	column = gtk_tree_view_column_new();
 	gtk_tree_view_append_column(view, column);
@@ -298,7 +298,7 @@  void init_right_tree(void)
 
 	gtk_tree_view_set_model(view, model2);
 	gtk_tree_view_set_headers_visible(view, TRUE);
-	gtk_tree_view_set_rules_hint(view, FALSE);
+	gtk_tree_view_set_rules_hint(view, TRUE);
 
 	column = gtk_tree_view_column_new();
 	gtk_tree_view_append_column(view, column);