From patchwork Sat May 21 08:21:48 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 805312 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4L8Mh2x016960 for ; Sat, 21 May 2011 08:22:43 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189Ab1EUIW2 (ORCPT ); Sat, 21 May 2011 04:22:28 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:35391 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753043Ab1EUIWK (ORCPT ); Sat, 21 May 2011 04:22:10 -0400 Received: by pvg12 with SMTP id 12so1968859pvg.19 for ; Sat, 21 May 2011 01:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=vD7/ddt+5dCtgMw2eaH1n+dHnTuvCWkXVpR3GeLVWVU=; b=mtcZTMM3u8PDKkDqA+BsdM8WuAgUForBZv5+G0XDQN/tekpPgftZWgtBsHwQYBH/z6 29qMxgnkuFv//hP343TukPCR+T+dzqSoZdmrKZXCgPuaJ/nKNV6/aC5J4qVrQfWPetSu pNutgecQY24TGBAD3cp08jDwgMbX8g0WD4aA4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=Giz9/xbQY8idN+8pfhOKkUQ6WT84x4RYhWXVXN3HWbunF2RNX4rCtQphrZunW6/SwC MsMLpK9qdvPOfcBD5LIz7zEyKmMpBNRBmLVnRteh0Tf/zDcRqqwceNF6e5ZHcgbrqR3G 4qKC+haEgXcMnu+k1EIKetEVejX9e4O8gIHK0= Received: by 10.68.27.39 with SMTP id q7mr497723pbg.440.1305966129838; Sat, 21 May 2011 01:22:09 -0700 (PDT) Received: from localhost.localdomain (c-67-174-123-122.hsd1.co.comcast.net [67.174.123.122]) by mx.google.com with ESMTPS id q20sm2985706pbt.72.2011.05.21.01.22.08 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 May 2011 01:22:09 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, Jim Cromie Subject: [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr. Date: Sat, 21 May 2011 02:21:48 -0600 Message-Id: <1305966108-13399-4-git-send-email-jim.cromie@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1305966108-13399-1-git-send-email-jim.cromie@gmail.com> References: <1305966108-13399-1-git-send-email-jim.cromie@gmail.com> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sat, 21 May 2011 08:22:44 +0000 (UTC) Also count CONFIG_MODVERSION warnings, and print an NB message at start of SECTION 2 if any were issued. Section 2 will be empty if the build is lacking this CONFIG_ item, and user may have missed the warnings, as they're off screen. Signed-off-by: Jim Cromie --- scripts/export_report.pl | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/scripts/export_report.pl b/scripts/export_report.pl index 16bd240..14c1638 100644 --- a/scripts/export_report.pl +++ b/scripts/export_report.pl @@ -102,6 +102,8 @@ close($module_symvers); # # collect the usage count of each symbol. # +my $modversion_warnings = 0; + foreach my $thismod (@allcfiles) { my $module; @@ -132,7 +134,8 @@ foreach my $thismod (@allcfiles) { } } if ($state != 2) { - print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n"; + warn "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n"; + $modversion_warnings++; } close($module); } @@ -166,6 +169,9 @@ printf("SECTION 2:\n\tThis section reports export-symbol-usage of in-kernel modules. Each module lists the modules, and the symbols from that module that it uses. Each listed symbol reports the number of modules using it\n"); +print "\nNB: Got $modversion_warnings CONFIG_MODVERSION warnings\n\n" + if $modversion_warnings; + print "~"x80 , "\n"; for my $thismod (sort keys %MODULE) { my $list = $MODULE{$thismod};