diff mbox

[1/2] kconfig: Factor out conf_validate_choice_val() function from conf_read_simple()

Message ID 1312078662-20278-1-git-send-email-lacombar@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Arnaud Lacombe July 31, 2011, 2:17 a.m. UTC 
Hi,
On Sat, Jul 30, 2011 at 7:13 PM, David Woodhouse <dwmw2@infradead.org> wrote:
> We're going to want to do this from elsewhere, shortly...
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>
I would go a little further and apply the attached patch too, The two jump
site to `setsym' do not meet the conditionnal and can be avoided.

 - Arnaud

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Woodhouse July 31, 2011, 10:21 p.m. UTC | #1 
On Sat, 2011-07-30 at 22:17 -0400, Arnaud Lacombe wrote:
> 
> I would go a little further and apply the attached patch too, The two jump
> site to `setsym' do not meet the conditionnal and can be avoided. 

Makes sense. It also makes sense to do that as a separate patch; the one
moving code around should *just* move code around. Want to let me have a
Signed-off-by: for it, and I'll add it to
 git://git.infradead.org/users/dwmw2/x86merge.git

Thanks.
diff mbox

Patch

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 0341254..74dcfb1 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -284,7 +284,7 @@  load:
 				sym = sym_find(line + 2 + strlen(CONFIG_));
 				if (!sym) {
 					sym_add_change_count(1);
-					goto setsym;
+					continue;
 				}
 			} else {
 				sym = sym_lookup(line + 2 + strlen(CONFIG_), 0);
@@ -318,7 +318,7 @@  load:
 				sym = sym_find(line + strlen(CONFIG_));
 				if (!sym) {
 					sym_add_change_count(1);
-					goto setsym;
+					continue;
 				}
 			} else {
 				sym = sym_lookup(line + strlen(CONFIG_), 0);
@@ -335,7 +335,7 @@  load:
 				conf_warning("unexpected data");
 			continue;
 		}
-setsym:
 		if (sym && sym_is_choice_value(sym))
 			conf_validate_choice_val(sym, def, def_flags);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in