From patchwork Sun Jul 31 02:17:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Lacombe X-Patchwork-Id: 1023592 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6V2I4fc015333 for ; Sun, 31 Jul 2011 02:18:04 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203Ab1GaCRx (ORCPT ); Sat, 30 Jul 2011 22:17:53 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:57888 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997Ab1GaCRx (ORCPT ); Sat, 30 Jul 2011 22:17:53 -0400 Received: by iyb12 with SMTP id 12so5512725iyb.19 for ; Sat, 30 Jul 2011 19:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=JLQ+T1JjtLxeugJn5u1nsUh8bRkXemqH2XU3vLuikAI=; b=TZ+jS77zXad+0gItIOwwxjV05nE7kSwFmBRJZPmYJproemBfRTQqlOY2ji4HbXQQWs xSrVMtF1tiT3yU2hUiwJgxZJz3CGm5uOJehbLA1c/+BMWNQd1JZAFwAs/v4TxVSjB1IV x6dg18iKGTlJZZZtOYkzEnrZfAAzW6LcggimE= Received: by 10.231.73.200 with SMTP id r8mr1940465ibj.102.1312078672312; Sat, 30 Jul 2011 19:17:52 -0700 (PDT) Received: from localhost.localdomain (69-165-143-95.dsl.teksavvy.com [69.165.143.95]) by mx.google.com with ESMTPS id v16sm2408359ibf.59.2011.07.30.19.17.50 (version=SSLv3 cipher=OTHER); Sat, 30 Jul 2011 19:17:51 -0700 (PDT) From: Arnaud Lacombe To: David Woodhouse Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Arnaud Lacombe Subject: Re: [PATCH 1/2] kconfig: Factor out conf_validate_choice_val() function from conf_read_simple() Date: Sat, 30 Jul 2011 22:17:42 -0400 Message-Id: <1312078662-20278-1-git-send-email-lacombar@gmail.com> X-Mailer: git-send-email 1.7.6.153.g78432 In-Reply-To: <1312067626.22074.60.camel@i7.infradead.org> References: <1312067626.22074.60.camel@i7.infradead.org> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 31 Jul 2011 02:18:04 +0000 (UTC) Hi, On Sat, Jul 30, 2011 at 7:13 PM, David Woodhouse wrote: > We're going to want to do this from elsewhere, shortly... > > Signed-off-by: David Woodhouse > I would go a little further and apply the attached patch too, The two jump site to `setsym' do not meet the conditionnal and can be avoided. - Arnaud the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Signed-off-by: for it, and I'll add it to diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 0341254..74dcfb1 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -284,7 +284,7 @@ load: sym = sym_find(line + 2 + strlen(CONFIG_)); if (!sym) { sym_add_change_count(1); - goto setsym; + continue; } } else { sym = sym_lookup(line + 2 + strlen(CONFIG_), 0); @@ -318,7 +318,7 @@ load: sym = sym_find(line + strlen(CONFIG_)); if (!sym) { sym_add_change_count(1); - goto setsym; + continue; } } else { sym = sym_lookup(line + strlen(CONFIG_), 0); @@ -335,7 +335,7 @@ load: conf_warning("unexpected data"); continue; } -setsym: if (sym && sym_is_choice_value(sym)) conf_validate_choice_val(sym, def, def_flags); } -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in