From patchwork Thu Aug 9 13:23:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Pemberton X-Patchwork-Id: 1300771 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id D3A4240B28 for ; Thu, 9 Aug 2012 13:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755451Ab2HINc0 (ORCPT ); Thu, 9 Aug 2012 09:32:26 -0400 Received: from viridian.itc.Virginia.EDU ([128.143.12.139]:46823 "EHLO viridian.itc.Virginia.EDU" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489Ab2HINcY (ORCPT ); Thu, 9 Aug 2012 09:32:24 -0400 X-Greylist: delayed 540 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Aug 2012 09:32:24 EDT Received: by viridian.itc.Virginia.EDU (Postfix, from userid 1249) id 6ECD960743; Thu, 9 Aug 2012 09:23:23 -0400 (EDT) From: Bill Pemberton To: linux-kbuild@vger.kernel.org Cc: rostedt@goodmis.org Subject: [PATCH 1/4] localmodconfig: set default value for ksource in streamline_config.pl Date: Thu, 9 Aug 2012 09:23:20 -0400 Message-Id: <1344518603-19508-2-git-send-email-wfp5p@virginia.edu> X-Mailer: git-send-email 1.7.11.3 In-Reply-To: <1344518603-19508-1-git-send-email-wfp5p@virginia.edu> References: <1344518603-19508-1-git-send-email-wfp5p@virginia.edu> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Running streamline_config.pl as it's shown it in the comment header, you will get a warning about $ksource being uninitialized. This is because $ksource is set to ARGV[0], but the examples don't require any arguments. Fix by setting ksource to . if no ARGV[0] is given. This also fixes passing a config file to the script. For example, without this is if you run streamline_config.pl . config.old, it will ignore config.old and try to read .config anyway. With this change it will read config.old instead of .config -- which appears to be the intent of the code. Signed-off-by: Bill Pemberton --- scripts/kconfig/streamline_config.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl index 2fbbbc1d..e3687f9 100644 --- a/scripts/kconfig/streamline_config.pl +++ b/scripts/kconfig/streamline_config.pl @@ -135,7 +135,7 @@ GetOptions("localmodconfig" => \$localmodconfig, "localyesconfig" => \$localyesconfig); # Get the build source and top level Kconfig file (passed in) -my $ksource = $ARGV[0]; +my $ksource = ($ARGV[0] ? $ARGV[0] : '.'); my $kconfig = $ARGV[1]; my $lsmod_file = $ENV{'LSMOD'};