From patchwork Thu Aug 9 13:23:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Pemberton X-Patchwork-Id: 1300791 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 2B8433FD8D for ; Thu, 9 Aug 2012 13:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755467Ab2HINc3 (ORCPT ); Thu, 9 Aug 2012 09:32:29 -0400 Received: from viridian.itc.Virginia.EDU ([128.143.12.139]:46825 "EHLO viridian.itc.Virginia.EDU" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755460Ab2HINcY (ORCPT ); Thu, 9 Aug 2012 09:32:24 -0400 Received: by viridian.itc.Virginia.EDU (Postfix, from userid 1249) id A8B5C61686; Thu, 9 Aug 2012 09:23:23 -0400 (EDT) From: Bill Pemberton To: linux-kbuild@vger.kernel.org Cc: rostedt@goodmis.org Subject: [PATCH 4/4] localmodconfig: use my variable for loop in streamline_config.pl Date: Thu, 9 Aug 2012 09:23:23 -0400 Message-Id: <1344518603-19508-5-git-send-email-wfp5p@virginia.edu> X-Mailer: git-send-email 1.7.11.3 In-Reply-To: <1344518603-19508-1-git-send-email-wfp5p@virginia.edu> References: <1344518603-19508-1-git-send-email-wfp5p@virginia.edu> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org perlcritic complains about $kconfig being reused in the foreach loop at the end of read_kconfig. Change it to a my variable. Signed-off-by: Bill Pemberton --- scripts/kconfig/streamline_config.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl index 22b66ca..39b6314 100644 --- a/scripts/kconfig/streamline_config.pl +++ b/scripts/kconfig/streamline_config.pl @@ -252,7 +252,7 @@ sub read_kconfig { close($kinfile); # read in any configs that were found. - foreach $kconfig (@kconfigs) { + foreach my $kconfig (@kconfigs) { if (!defined($read_kconfigs{$kconfig})) { $read_kconfigs{$kconfig} = 1; read_kconfig($kconfig);