From patchwork Tue Aug 14 16:00:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ozan_=C3=87a=3Flayan?= X-Patchwork-Id: 1321521 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 31D0140210 for ; Tue, 14 Aug 2012 16:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755419Ab2HNQBE (ORCPT ); Tue, 14 Aug 2012 12:01:04 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:36241 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724Ab2HNQBC (ORCPT ); Tue, 14 Aug 2012 12:01:02 -0400 Received: by eeil10 with SMTP id l10so217611eei.19 for ; Tue, 14 Aug 2012 09:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=GUpQ6zbQJWgUi1WjWk51po5/7mEujGjLC+7YD5d+Mzg=; b=yGfkG6byHvCeGiQhywqXvCw3o7h2RnNLH89l8zKfke8uxR9RrSRrlQpp+DTglUv9np XNZmOe54d/j6oOHvUjHwUW7fE3GO0twSxWAAcId46Ujqfd6KYIaX9nja3vEDhpsqSVeu yICdTKOip3PVxnF7PfAcq6RmesnWGemAzHn8jySHGRkHXUHAtLzOf4Ju/daDzoO/Fqj9 uDfTmMLCmR/TT2oE4QazNnQq7+zQEvYx4UOf1uiVPMmqsoL0EokSBfOjsPjmOPbkObvR jsabuoCRA8FQ9/neA8s6g8kidsVCTPcgc7IoM3gaLmvzILTXxnBObfKl0H2402LC4Jyz feBA== Received: by 10.14.224.4 with SMTP id w4mr7466490eep.21.1344960060963; Tue, 14 Aug 2012 09:01:00 -0700 (PDT) Received: from localhost.localdomain ([81.214.87.249]) by mx.google.com with ESMTPS id u8sm7940761eel.11.2012.08.14.09.00.59 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 14 Aug 2012 09:01:00 -0700 (PDT) From: =?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= To: linux-kernel@vger.kernel.org Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org, sam@ravnborg.org, artem.bityutskiy@linux.intel.com, =?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= Subject: [PATCH] kbuild: Remove useless warning while appending KCFLAGS Date: Tue, 14 Aug 2012 19:00:54 +0300 Message-Id: <1344960054-26557-1-git-send-email-ozancag@gmail.com> X-Mailer: git-send-email 1.7.11.2 MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org This is a respin of an older patch sent by Sam Ravnborg: http://www.gossamer-threads.com/lists/linux/kernel/1530602 This patch removes the annoying warning: Makefile:708: "WARNING: Appending $KCFLAGS (-Wno-sign-compare) from command line to kernel $CFLAGS" which is printed every time I use KCFLAFS. The commit which introduced the warning: 69ee0b3 kbuild: do not pick up CFLAGS from the environment tells about the problems when people have CFLAGS in their environment, then switches to KCFLAFS which should be enough to solve the issue, but it anyway introduces a warning. Drop this warning. Signed-off-by: Ozan Ça?layan --- Makefile | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/Makefile b/Makefile index 0d718ed..34751eb 100644 --- a/Makefile +++ b/Makefile @@ -648,22 +648,9 @@ ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y) endif # Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments -# But warn user when we do so -warn-assign = \ -$(warning "WARNING: Appending $$K$(1) ($(K$(1))) from $(origin K$(1)) to kernel $$$(1)") - -ifneq ($(KCPPFLAGS),) - $(call warn-assign,CPPFLAGS) - KBUILD_CPPFLAGS += $(KCPPFLAGS) -endif -ifneq ($(KAFLAGS),) - $(call warn-assign,AFLAGS) - KBUILD_AFLAGS += $(KAFLAGS) -endif -ifneq ($(KCFLAGS),) - $(call warn-assign,CFLAGS) - KBUILD_CFLAGS += $(KCFLAGS) -endif +KBUILD_CPPFLAGS += $(KCPPFLAGS) +KBUILD_AFLAGS += $(KAFLAGS) +KBUILD_CFLAGS += $(KCFLAGS) # Use --build-id when available. LDFLAGS_BUILD_ID = $(patsubst -Wl$(comma)%,%,\