| Message ID | 1345186649-17502-1-git-send-email-adam8157@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote: > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target > 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but > instead sets it to their default values. > > This patch fixes the document in conf.c, and will submit another patch > to replace 'oldnoconfig' to 'olddefconfig' > > Signed-off-by: Adam Lee <adam8157@gmail.com> > --- > scripts/kconfig/conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, I think we should apply this patch, any comment? I was confused by the different documents of `make help` and usage of "scripts/kconfig/conf.c" before I got through conf.c and checked the git log. Others maybe confused too. So I think we really should apply this patch at least. As regards whether that target should be renamed to 'olddefconfig', we can discuss it at another thread. Thank you.
On Wed, Aug 22, 2012 at 09:45:19PM +0800, Adam Lee wrote: > On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote: > > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target > > 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but > > instead sets it to their default values. > > > > This patch fixes the document in conf.c, and will submit another patch > > to replace 'oldnoconfig' to 'olddefconfig' > > > > Signed-off-by: Adam Lee <adam8157@gmail.com> > > --- > > scripts/kconfig/conf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi, > > I think we should apply this patch, any comment? Sorry for the delay. I applied it to kbuild.git#kconfig now. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 0dc4a2c..6875680 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -467,7 +467,7 @@ static void conf_usage(const char *progname) printf(" --oldaskconfig Start a new configuration using a line-oriented program\n"); printf(" --oldconfig Update a configuration using a provided .config as base\n"); printf(" --silentoldconfig Same as oldconfig, but quietly, additionally update deps\n"); - printf(" --oldnoconfig Same as silentoldconfig but set new symbols to no\n"); + printf(" --oldnoconfig Same as silentoldconfig but sets new symbols to their default value\n"); printf(" --defconfig <file> New config with default defined in <file>\n"); printf(" --savedefconfig <file> Save the minimal current configuration to <file>\n"); printf(" --allnoconfig New config where all options are answered with no\n");
As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but instead sets it to their default values. This patch fixes the document in conf.c, and will submit another patch to replace 'oldnoconfig' to 'olddefconfig' Signed-off-by: Adam Lee <adam8157@gmail.com> --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)