diff mbox

buildtar: Add ARCH to the archive name

Message ID 1362557147-14393-1-git-send-email-bp@alien8.de (mailing list archive)
State New, archived
Headers show

Commit Message

Borislav Petkov March 6, 2013, 8:05 a.m. UTC
From: Borislav Petkov <bp@suse.de>

When dealing with multiple sub-arches (like 32- and 64-bit on x86, for
example) generating a bunch of kernel tar archives with the same name
but for different sub-arches could get confusing and error-prone. Also,
the build process could overwrite otherwise unrelated builds and you
probably don't want that. So, add the architecture to the archive name
for more clarity and less shoot-yourself-in-the-foot practices.

Signed-off-by: Borislav Petkov <bp@suse.de>
---
 scripts/package/buildtar | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joerg Roedel March 7, 2013, 11:06 a.m. UTC | #1
On Wed, Mar 06, 2013 at 09:05:47AM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> When dealing with multiple sub-arches (like 32- and 64-bit on x86, for
> example) generating a bunch of kernel tar archives with the same name
> but for different sub-arches could get confusing and error-prone. Also,
> the build process could overwrite otherwise unrelated builds and you
> probably don't want that. So, add the architecture to the archive name
> for more clarity and less shoot-yourself-in-the-foot practices.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>

Good idea, but I already hear people yelling about their scripts that
break with this change :)


	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Borislav Petkov March 7, 2013, 11:09 a.m. UTC | #2
On Thu, Mar 07, 2013 at 12:06:59PM +0100, Joerg Roedel wrote:
> Good idea, but I already hear people yelling about their scripts that
> break with this change :)

They better fix them then. :-)
Michal Marek April 8, 2013, 2:05 p.m. UTC | #3
On 7.3.2013 12:09, Borislav Petkov wrote:
> On Thu, Mar 07, 2013 at 12:06:59PM +0100, Joerg Roedel wrote:
>> Good idea, but I already hear people yelling about their scripts that
>> break with this change :)
> 
> They better fix them then. :-)

OK, I applied the patch to kbuild.git#misc. Let's see how many people
protest...

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Borislav Petkov April 8, 2013, 2:26 p.m. UTC | #4
On Mon, Apr 08, 2013 at 04:05:53PM +0200, Michal Marek wrote:
> On 7.3.2013 12:09, Borislav Petkov wrote:
> > On Thu, Mar 07, 2013 at 12:06:59PM +0100, Joerg Roedel wrote:
> >> Good idea, but I already hear people yelling about their scripts that
> >> break with this change :)
> > 
> > They better fix them then. :-)
> 
> OK, I applied the patch to kbuild.git#misc. Let's see how many people
> protest...

Yeah, leave it in there for 3.10 so that it sees a whole cycle of
testing in -next and what not, so that we can see who complains. :)

Thanks.
Borislav Petkov Sept. 12, 2013, 12:46 p.m. UTC | #5
On Wed, Sep 11, 2013 at 06:35:08PM -0500, Josh Hunt wrote:
> I didn't take the time to build the rpm pkg, but deb-pkg produces files
> like:
> 
> linux-image-3.10.0-rc7_3.10.0-rc7-26_amd64.deb
> 
> tarbz2-pkg now produces files with the name of:
> linux-3.10.0-rc7-x86.tar.bz2

Right, I'm not really happy with this solution too because builds which
don't supply ARCH on the command line add "x86" to the archive name
and my intention was to have either "i386" or "x86_64" appended to the
archive name so that when building a bunch of different kernel packages,
I can know which is 32-bit and which is 64-bit.

Having it say "x86" doesn't tell me all that much. Whether it has "-" or
an "_" prepended I don't care.

So I'll go and revisit this thing. I'll add you to CC for feedback since
your script got broke :)

And, btw, other suggestions are appreciated too.

Thanks.
diff mbox

Patch

diff --git a/scripts/package/buildtar b/scripts/package/buildtar
index 62d8234f8787..cdd9bb909bcd 100644
--- a/scripts/package/buildtar
+++ b/scripts/package/buildtar
@@ -16,7 +16,7 @@  set -e
 # Some variables and settings used throughout the script
 #
 tmpdir="${objtree}/tar-install"
-tarball="${objtree}/linux-${KERNELRELEASE}.tar"
+tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
 
 
 #