diff mbox

[V2,2/3] frv: Remove redundant debugging info flag

Message ID 1390873714.5027.55.camel@smoke (mailing list archive)
State New, archived
Headers show

Commit Message

Geoff Levand Jan. 28, 2014, 1:48 a.m. UTC
The generic makefile now sets '-Wa,--gdwarf2' in KBUILD_AFLAGS, so
this setting is no longer needed in arch makefiles.

Also remove a commented out addition of a -O1 to KBUILD_CFLAGS, and
comment text relating to these removed lines.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
---
v2: Removed unused CONFIG_DEBUG_INFO conditional and related text comment.

 arch/frv/Makefile | 7 -------
 1 file changed, 7 deletions(-)

Comments

Michal Marek Jan. 28, 2014, 10:16 a.m. UTC | #1
On 28.1.2014 02:48, Geoff Levand wrote:
> The generic makefile now sets '-Wa,--gdwarf2' in KBUILD_AFLAGS, so
> this setting is no longer needed in arch makefiles.
> 
> Also remove a commented out addition of a -O1 to KBUILD_CFLAGS, and
> comment text relating to these removed lines.
> 
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
> ---
> v2: Removed unused CONFIG_DEBUG_INFO conditional and related text comment.

Thanks, I added v2 of 2/3 and 3/3 to kbuild.git#kbuild.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/frv/Makefile b/arch/frv/Makefile
index 4d1b1e9..2a8fb73 100644
--- a/arch/frv/Makefile
+++ b/arch/frv/Makefile
@@ -74,13 +74,6 @@  KBUILD_CFLAGS	+= -mno-fdpic -mgpr-32 -msoft-float -mno-media
 KBUILD_CFLAGS	+= -ffixed-fcc3 -ffixed-cc3 -ffixed-gr15 -ffixed-icc2
 KBUILD_AFLAGS	+= -mno-fdpic
 
-# make sure the .S files get compiled with debug info
-# and disable optimisations that are unhelpful whilst debugging
-ifdef CONFIG_DEBUG_INFO
-#KBUILD_CFLAGS	+= -O1
-KBUILD_AFLAGS	+= -Wa,--gdwarf2
-endif
-
 head-y		:= arch/frv/kernel/head.o
 
 core-y		+= arch/frv/kernel/ arch/frv/mm/