| Message ID | 1391846481-31491-17-git-send-email-ak@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Andi Kleen <ak@linux.intel.com> writes: > When __gnu_lto_* is present that means that the module hasn't run with > LTO yet. In practice, this means they didn't build their kernel properly, right? It shouldn't break anything, but it seems really weird. And how many times will the prink fire on a single module? Seems like a job for pr_warn? Thanks, Rusty. > --- > kernel/module.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/kernel/module.c b/kernel/module.c > index b99e801..2052155 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -1949,8 +1949,11 @@ static int simplify_symbols(struct module *mod, const struct load_info *info) > switch (sym[i].st_shndx) { > case SHN_COMMON: > /* Ignore common symbols */ > - if (!strncmp(name, "__gnu_lto", 9)) > + if (!strncmp(name, "__gnu_lto", 9)) { > + printk("%s: module not link time optimized\n", > + mod->name); > break; > + } > > /* We compiled with -fno-common. These are not > supposed to happen. */ > -- > 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/kernel/module.c b/kernel/module.c index b99e801..2052155 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1949,8 +1949,11 @@ static int simplify_symbols(struct module *mod, const struct load_info *info) switch (sym[i].st_shndx) { case SHN_COMMON: /* Ignore common symbols */ - if (!strncmp(name, "__gnu_lto", 9)) + if (!strncmp(name, "__gnu_lto", 9)) { + printk("%s: module not link time optimized\n", + mod->name); break; + } /* We compiled with -fno-common. These are not supposed to happen. */
When __gnu_lto_* is present that means that the module hasn't run with LTO yet. Cc: rusty@rustcorp.com.au Signed-off-by: Andi Kleen <ak@linux.intel.com> --- kernel/module.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)