From patchwork Fri Feb 14 21:17:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Kleen X-Patchwork-Id: 3654251 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EFF0ABF13A for ; Fri, 14 Feb 2014 21:20:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3A57B201C7 for ; Fri, 14 Feb 2014 21:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 598BF201BF for ; Fri, 14 Feb 2014 21:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752911AbaBNVTu (ORCPT ); Fri, 14 Feb 2014 16:19:50 -0500 Received: from mga09.intel.com ([134.134.136.24]:52266 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbaBNVR5 (ORCPT ); Fri, 14 Feb 2014 16:17:57 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 14 Feb 2014 13:13:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,847,1384329600"; d="scan'208";a="475471039" Received: from laut.jf.intel.com (HELO localhost) ([10.23.232.94]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2014 13:17:54 -0800 Received: by localhost (Postfix, from userid 1000) id A5D98124B09; Fri, 14 Feb 2014 22:17:14 +0100 (CET) From: Andi Kleen To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, linux-kbuild@vger.kernel.org, mmarek@suse.cz, Andi Kleen Subject: [PATCH 3/6] kbuild: Don't include const variable in kallsyms with !KALLSYMS_ALL Date: Fri, 14 Feb 2014 22:17:06 +0100 Message-Id: <1392412629-25666-4-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1392412629-25666-1-git-send-email-andi@firstfloor.org> References: <1392412629-25666-1-git-send-email-andi@firstfloor.org> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Andi Kleen const variables are put into the text segment, so !KALLSYMS_ALL includes them into the kallsyms section. Remove them to make the kallsyms smaller. This also avoids some problems with LTO. The way LTO generates the first pass kallsyms cannot handle variables currently, so if we don't filter them out the first and second level pass differ too much. Signed-off-by: Andi Kleen --- scripts/kallsyms.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index ceef756..d79027e 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -151,6 +151,11 @@ static int read_symbol(FILE *in, struct sym_entry *s) /* exclude debugging symbols */ else if (stype == 'N') return -1; + /* Don't include const symbols in the text section + * unless --all-symbols is specified. + */ + else if (toupper(stype) != 'T' && !all_symbols) + return -1; /* include the type field in the symbol name, so that it gets * compressed together */