From patchwork Fri Aug 1 04:08:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Behan Webster X-Patchwork-Id: 4660281 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 312D6C0338 for ; Fri, 1 Aug 2014 04:08:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4D841201BB for ; Fri, 1 Aug 2014 04:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CB922017A for ; Fri, 1 Aug 2014 04:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750875AbaHAEIb (ORCPT ); Fri, 1 Aug 2014 00:08:31 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:40954 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaHAEIa (ORCPT ); Fri, 1 Aug 2014 00:08:30 -0400 Received: by mail-pa0-f41.google.com with SMTP id rd3so4963028pab.0 for ; Thu, 31 Jul 2014 21:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=converseincode.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=8zbxZLSPtLGM4Qwl/3pIvIdqzPR183ZRYLYOfy07J5I=; b=XRuhT9SVmb7xrX/6BPw5F5NiRq1MQaCf27tFEfWvcs9DJeb/KZEMWuN2GPuXgvKPAB AIwzldl38f0RSMEZCLUk5x6mD6vWpZlYS8DFSg9YS5ecoZynV8orzy9TYXufYNtYRcWQ oeIOD46E173zquh51S5o9aqYQccSFzwTrgHXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=8zbxZLSPtLGM4Qwl/3pIvIdqzPR183ZRYLYOfy07J5I=; b=a20oVyGG4pXzg4N3WO/jjp+FTWYVnF63333y2sEVXPc10vkhcPNw7pcKcLB+3VpPUZ oePDT7Pr/Bw2a7+fp/DtOttszoe6/g5OsjjZMa47bITHncEEYJfJLfsxnOV0zLU8mR9t YPA+wMr13r7gq61B6scPVFAvdSSTUCRmQaM5pvokhiT0mQU2YJVlenI0ZKTAe2NHai7L H5SDGXPH9wE5LxIBa1Z+WJ3tQ6DikqIKGb/1Pr9JemiJIJeyQ17tZ8GPe5qpxLWRS467 80mSxqiPk5JHChGkhr0xJb1Hcim5x99fRUXXfjzpzTf1Odq1ZV4CrMW24Dq0CI7zpKGZ FQFA== X-Gm-Message-State: ALoCoQlBF6vVopA+aRJbF02uXRLFBKqsGpvyLvKnR2fXgW5yk3rUW9AVbY2I4hAdA1Omoa3cug7x X-Received: by 10.68.213.34 with SMTP id np2mr11919pbc.167.1406866110123; Thu, 31 Jul 2014 21:08:30 -0700 (PDT) Received: from galdor.websterwood.com (S0106dc9fdb80cffd.gv.shawcable.net. [96.50.97.138]) by mx.google.com with ESMTPSA id n8sm10890698pdm.22.2014.07.31.21.08.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 31 Jul 2014 21:08:29 -0700 (PDT) From: behanw@converseincode.com To: mmarek@suse.cz Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, Behan Webster , =?UTF-8?q?Jan-Simon=20M=C3=B6ller?= , Mark Charlebois , bp@alien8.de Subject: [PATCH v3] kbuild, LLVMLinux: Supress warnings unless W=1-3 Date: Thu, 31 Jul 2014 21:08:25 -0700 Message-Id: <1406866105-24980-1-git-send-email-behanw@converseincode.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <53DAAB35.8080206@suse.cz> References: <53DAAB35.8080206@suse.cz> MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Behan Webster clang has more warnings enabled by default. Turn them off unless W is set. This patch fixes a logic bug where warnings in clang were disabled when W was set. Signed-off-by: Behan Webster Signed-off-by: Jan-Simon Möller Signed-off-by: Mark Charlebois Cc: mmarek@suse.cz Cc: bp@alien8.de --- Makefile | 1 + scripts/Makefile.extrawarn | 22 ++++++++++++---------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index f6a7794..f343e17 100644 --- a/Makefile +++ b/Makefile @@ -668,6 +668,7 @@ KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare) # source of a reference will be _MergedGlobals and not on of the whitelisted names. # See modpost pattern 2 KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,) +KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior) else # This warning generated too much noise in a regular build. diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 6564350..4315d34 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -26,16 +26,6 @@ warning-1 += $(call cc-option, -Wmissing-include-dirs) warning-1 += $(call cc-option, -Wunused-but-set-variable) warning-1 += $(call cc-disable-warning, missing-field-initializers) -# Clang -warning-1 += $(call cc-disable-warning, initializer-overrides) -warning-1 += $(call cc-disable-warning, unused-value) -warning-1 += $(call cc-disable-warning, format) -warning-1 += $(call cc-disable-warning, unknown-warning-option) -warning-1 += $(call cc-disable-warning, sign-compare) -warning-1 += $(call cc-disable-warning, format-zero-length) -warning-1 += $(call cc-disable-warning, uninitialized) -warning-1 += $(call cc-option, -fcatch-undefined-behavior) - warning-2 := -Waggregate-return warning-2 += -Wcast-align warning-2 += -Wdisabled-optimization @@ -64,4 +54,16 @@ ifeq ("$(strip $(warning))","") endif KBUILD_CFLAGS += $(warning) +else + +ifeq ($(COMPILER),clang) +KBUILD_CFLAGS += $(call cc-disable-warning, initializer-overrides) +KBUILD_CFLAGS += $(call cc-disable-warning, unused-value) +KBUILD_CFLAGS += $(call cc-disable-warning, format) +KBUILD_CFLAGS += $(call cc-disable-warning, unknown-warning-option) +KBUILD_CFLAGS += $(call cc-disable-warning, sign-compare) +KBUILD_CFLAGS += $(call cc-disable-warning, format-zero-length) +KBUILD_CFLAGS += $(call cc-disable-warning, uninitialized) endif +endif +