From patchwork Tue Nov 4 11:01:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Peter_K=C3=BCmmel?= X-Patchwork-Id: 5225601 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DAA389F349 for ; Tue, 4 Nov 2014 11:02:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D651201F5 for ; Tue, 4 Nov 2014 11:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1E0D2010F for ; Tue, 4 Nov 2014 11:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbaKDLCI (ORCPT ); Tue, 4 Nov 2014 06:02:08 -0500 Received: from mout.gmx.net ([212.227.15.19]:65169 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaKDLCH (ORCPT ); Tue, 4 Nov 2014 06:02:07 -0500 Received: from localhost.localdomain ([92.226.39.162]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M54s2-1XyBVr01zK-00zCWD; Tue, 04 Nov 2014 12:02:05 +0100 From: =?UTF-8?q?Peter=20K=C3=BCmmel?= To: linux-kbuild@vger.kernel.org Cc: yann.morin.1998@free.fr, =?UTF-8?q?Peter=20K=C3=BCmmel?= Subject: [PATCH v2] =?UTF-8?q?kconfig:=20Fix=20warning=20"=E2=80=98jump?= =?UTF-8?q?=E2=80=99=20may=20be=20used=20uninitialized"?= Date: Tue, 4 Nov 2014 12:01:59 +0100 Message-Id: <1415098919-21836-1-git-send-email-syntheticpp@gmx.net> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Provags-ID: V03:K0:Mm1B9gEvS2jIN6H3Ge2fRXg0X4BqL9PI5IO9H6noFIKa6KujTeS YEXMIpVZSIapyfOZCHyw5fDPL4nISj4Ppr+4FNjnXG6mhZjsix2IseSACm/19echj4MD749 r6MNCVll7WL29ioRfupnBxKjMjXZpsIvU8Hvie3UhO215Qz/GiDVrA/XVVjF5ofZqxdJu5A 9BVJhoZe5vRWszpziUmPw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Warning: In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c: In function ‘get_symbol_str’: scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] jump->offset = strlen(r->s); Simplifies the test logic because (head && local) means (jump != 0) and makes GCC happy when checking if the jump pointer was initialized. Signed-off-by: Peter Kümmel --- scripts/kconfig/menu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index a26cc5d..72c9dba 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, { int i, j; struct menu *submenu[8], *menu, *location = NULL; - struct jump_key *jump; + struct jump_key *jump = NULL; str_printf(r, _("Prompt: %s\n"), _(prop->text)); menu = prop->menu->parent; @@ -586,7 +586,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, str_printf(r, _(" Location:\n")); for (j = 4; --i >= 0; j += 2) { menu = submenu[i]; - if (head && location && menu == location) + if (jump && menu == location) jump->offset = strlen(r->s); str_printf(r, "%*c-> %s", j, ' ', _(menu_get_prompt(menu)));