diff mbox

kbuild: update headers_install.txt document

Message ID 1417589141-14814-1-git-send-email-yamada.m@jp.panasonic.com (mailing list archive)
State New, archived
Headers show

Commit Message

Masahiro Yamada Dec. 3, 2014, 6:45 a.m. UTC
The arch header directories "include/asm-*" were moved long ago.
Now we should check the existence of arch/*/include/uapi/asm/Kbuild
to see if an architecture supports the headers installation.
(Actually, "um" is the only architecture that does not have it.)

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 Documentation/kbuild/headers_install.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Corbet Dec. 3, 2014, 2:02 p.m. UTC | #1
On Wed,  3 Dec 2014 15:45:41 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:

> The arch header directories "include/asm-*" were moved long ago.
> Now we should check the existence of arch/*/include/uapi/asm/Kbuild
> to see if an architecture supports the headers installation.
> (Actually, "um" is the only architecture that does not have it.)
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

So please forgive me if I seem overly difficult and fussy, but...  while
I'm all for fancy shell one-liners, wouldn't it be more straightforward,
in this case, to simply say in the documentation that all architectures
other than um have support?

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
index 951eb9f..8e668d4 100644
--- a/Documentation/kbuild/headers_install.txt
+++ b/Documentation/kbuild/headers_install.txt
@@ -31,7 +31,7 @@  current architecture.  The linux/asm directory of the exported kernel headers
 is platform-specific, to see a complete list of supported architectures use
 the command:
 
-  ls -d include/asm-* | sed 's/.*-//'
+  for i in arch/*; do [ -e $i/include/uapi/asm/Kbuild ] && basename $i; done
 
 INSTALL_HDR_PATH indicates where to install the headers.  It defaults to
 "./usr/include".