diff mbox

kconfig: add missing va_end()

Message ID 1426699007-10933-1-git-send-email-johannes@sipsolutions.net (mailing list archive)
State New, archived
Headers show

Commit Message

Johannes Berg March 18, 2015, 5:16 p.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

This was pointed out by static checker analysis, but is likely
otherwise harmless. Add it anyway to confuse the reader less.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 scripts/kconfig/confdata.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul Bolle March 18, 2015, 5:48 p.m. UTC | #1
[Removed Yann.]

On Wed, 2015-03-18 at 18:16 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> This was pointed out by static checker analysis, but is likely
> otherwise harmless. Add it anyway to confuse the reader less.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  scripts/kconfig/confdata.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index f88d90f20228..28df18dd1147 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -59,6 +59,7 @@ static void conf_message(const char *fmt, ...)
>  	va_start(ap, fmt);
>  	if (conf_message_callback)
>  		conf_message_callback(fmt, ap);
> +	va_end(ap);
>  }
>  
>  const char *conf_get_configname(void)

This is fixed since v4.0-rc1 with commit b6a2ab2cd473 ("kconfig: use
va_end to match corresponding va_start"). Did that checker find anything
else noteworthy in scripts/kconfig?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg March 18, 2015, 6:55 p.m. UTC | #2
On Wed, 2015-03-18 at 18:48 +0100, Paul Bolle wrote:

> This is fixed since v4.0-rc1 with commit b6a2ab2cd473 ("kconfig: use
> va_end to match corresponding va_start"). 

Heh, sorry for the noise. I'm still on 3.19-ish on my tree.

> Did that checker find anything
> else noteworthy in scripts/kconfig?

Not that I know of.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index f88d90f20228..28df18dd1147 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -59,6 +59,7 @@  static void conf_message(const char *fmt, ...)
 	va_start(ap, fmt);
 	if (conf_message_callback)
 		conf_message_callback(fmt, ap);
+	va_end(ap);
 }
 
 const char *conf_get_configname(void)