| Message ID | 1459625933-20677-1-git-send-email-robert.jarzmik@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Apr 02, 2016 at 09:38:53PM +0200, Robert Jarzmik wrote: > When the kernel path contains a space or a colon somewhere in the path > name, the modules_install target doesn't work anymore, as the path names > are not enclosed in double quotes. It is also supposed that and O= build > will suffer from the same weakness as modules_install. > > Instead of checking and improving kbuild to resist to directories > including these characters, error out early to prevent any build if the > kernel's main directory contains a space. > > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> > --- > Since v1: add colon check as requested by Michal. > --- > Makefile | 4 ++++ > 1 file changed, 4 insertions(+) Applied to kbuild.git#kbuild. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Makefile b/Makefile index 916b26e999d8..42e01dab13e7 100644 --- a/Makefile +++ b/Makefile @@ -128,6 +128,10 @@ _all: # Cancel implicit rules on top Makefile $(CURDIR)/Makefile Makefile: ; +ifneq ($(words $(subst :, ,$(CURDIR))), 1) + $(error main directory cannot contain spaces nor colons) +endif + ifneq ($(KBUILD_OUTPUT),) # Invoke a second make in the output directory, passing relevant variables # check that the output directory actually exists
When the kernel path contains a space or a colon somewhere in the path name, the modules_install target doesn't work anymore, as the path names are not enclosed in double quotes. It is also supposed that and O= build will suffer from the same weakness as modules_install. Instead of checking and improving kbuild to resist to directories including these characters, error out early to prevent any build if the kernel's main directory contains a space. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> --- Since v1: add colon check as requested by Michal. --- Makefile | 4 ++++ 1 file changed, 4 insertions(+)