| Message ID | 1467903037-11785-1-git-send-email-henning.schild@siemens.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016-07-07 16:50, Henning Schild wrote: > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting linux-headers package will prevent non-root users > from building out-of-tree modules. And that is probably just one > unexpected effect. > Being a packaging/install tool builddep should make sure the file > permissions are set correctly and not just derived from a value that is > never checked. > > This patch derives the "r" and "x" bits for all files from the file > owner, all directories in the package will be 755. > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > --- > scripts/package/builddeb | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > index 86e56fe..615e0ed 100755 > --- a/scripts/package/builddeb > +++ b/scripts/package/builddeb > @@ -26,6 +26,11 @@ create_package() { > # Fix ownership and permissions > chown -R root:root "$pdir" > chmod -R go-w "$pdir" > + # in case we are in a restrictive umask environment like 0077 > + # set permissions for dirs and derive "go"-"rx" permissions from "u" > + find $pdir -type d -exec chmod 0755 {} + > + find $pdir -type f -perm -u+r -exec chmod go+r {} + > + find $pdir -type f -perm -u+x -exec chmod go+x {} + This can be simplified as chmod -R a+rX "$pdir" Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Fri, 22 Jul 2016 14:15:32 +0200 schrieb Michal Marek <mmarek@suse.com>: > On 2016-07-07 16:50, Henning Schild wrote: > > Builddep is not very explicit about file permissions. Actually the > > file permissions in the package are largely influenced by the umask > > of the user cloning the git and building the package. If that umask > > does not set go+r the resulting linux-headers package will prevent > > non-root users from building out-of-tree modules. And that is > > probably just one unexpected effect. > > Being a packaging/install tool builddep should make sure the file > > permissions are set correctly and not just derived from a value > > that is never checked. > > > > This patch derives the "r" and "x" bits for all files from the file > > owner, all directories in the package will be 755. > > > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > --- > > scripts/package/builddeb | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > > index 86e56fe..615e0ed 100755 > > --- a/scripts/package/builddeb > > +++ b/scripts/package/builddeb > > @@ -26,6 +26,11 @@ create_package() { > > # Fix ownership and permissions > > chown -R root:root "$pdir" > > chmod -R go-w "$pdir" > > + # in case we are in a restrictive umask environment like > > 0077 > > + # set permissions for dirs and derive "go"-"rx" > > permissions from "u" > > + find $pdir -type d -exec chmod 0755 {} + > > + find $pdir -type f -perm -u+r -exec chmod go+r {} + > > + find $pdir -type f -perm -u+x -exec chmod go+x {} + > > This can be simplified as > > chmod -R a+rX "$pdir" That 'X' is much nicer than the finds, learned something new today, Thanks! Henning > Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 86e56fe..615e0ed 100755 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -26,6 +26,11 @@ create_package() { # Fix ownership and permissions chown -R root:root "$pdir" chmod -R go-w "$pdir" + # in case we are in a restrictive umask environment like 0077 + # set permissions for dirs and derive "go"-"rx" permissions from "u" + find $pdir -type d -exec chmod 0755 {} + + find $pdir -type f -perm -u+r -exec chmod go+r {} + + find $pdir -type f -perm -u+x -exec chmod go+x {} + # Create the package dpkg-gencontrol $forcearch -Vkernel:debarch="${debarch}" -p$pname -P"$pdir"
Builddep is not very explicit about file permissions. Actually the file permissions in the package are largely influenced by the umask of the user cloning the git and building the package. If that umask does not set go+r the resulting linux-headers package will prevent non-root users from building out-of-tree modules. And that is probably just one unexpected effect. Being a packaging/install tool builddep should make sure the file permissions are set correctly and not just derived from a value that is never checked. This patch derives the "r" and "x" bits for all files from the file owner, all directories in the package will be 755. Signed-off-by: Henning Schild <henning.schild@siemens.com> --- scripts/package/builddeb | 5 +++++ 1 file changed, 5 insertions(+)