diff mbox

[v5,6/8] uapi: includes linux/types.h before exporting files

Message ID 1486041910-2665-7-git-send-email-nicolas.dichtel@6wind.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nicolas Dichtel Feb. 2, 2017, 1:25 p.m. UTC
Some files will be exported after the next patch. 0-day tests report the
following warning/error:
./usr/include/linux/bcache.h:8: include of <linux/types.h> is preferred over <asm/types.h>
./usr/include/linux/bcache.h:11: found __[us]{8,16,32,64} type without #include <linux/types.h>
./usr/include/linux/qrtr.h:8: found __[us]{8,16,32,64} type without #include <linux/types.h>
./usr/include/linux/cryptouser.h:39: found __[us]{8,16,32,64} type without #include <linux/types.h>
./usr/include/linux/media.h:29: included file 'linux/version.h' is not exported
./usr/include/linux/pr.h:14: found __[us]{8,16,32,64} type without #include <linux/types.h>
./usr/include/linux/btrfs_tree.h:337: found __[us]{8,16,32,64} type without #include <linux/types.h>
./usr/include/linux/seg6.h:21: found __[us]{8,16,32,64} type without #include <linux/types.h>
./usr/include/linux/seg6_hmac.h:11: found __[us]{8,16,32,64} type without #include <linux/types.h>

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 include/uapi/linux/bcache.h     | 2 +-
 include/uapi/linux/btrfs_tree.h | 2 ++
 include/uapi/linux/cryptouser.h | 2 ++
 include/uapi/linux/media.h      | 1 -
 include/uapi/linux/pr.h         | 2 ++
 include/uapi/linux/seg6.h       | 2 ++
 6 files changed, 9 insertions(+), 2 deletions(-)

Comments

kernel test robot Feb. 2, 2017, 3:15 p.m. UTC | #1
Hi Nicolas,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.10-rc6 next-20170202]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/uapi-export-all-headers-under-uapi-directories/20170202-213944
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/media/media-device.c:30:0:
   drivers/media/media-device.c: In function 'media_device_get_info':
>> include/uapi/linux/media.h:32:27: error: implicit declaration of function 'KERNEL_VERSION' [-Werror=implicit-function-declaration]
    #define MEDIA_API_VERSION KERNEL_VERSION(0, 1, 0)
                              ^
>> drivers/media/media-device.c:76:24: note: in expansion of macro 'MEDIA_API_VERSION'
     info->media_version = MEDIA_API_VERSION;
                           ^~~~~~~~~~~~~~~~~
   drivers/media/media-device.c: In function 'media_device_pci_init':
>> drivers/media/media-device.c:841:25: error: 'LINUX_VERSION_CODE' undeclared (first use in this function)
     mdev->driver_version = LINUX_VERSION_CODE;
                            ^~~~~~~~~~~~~~~~~~
   drivers/media/media-device.c:841:25: note: each undeclared identifier is reported only once for each function it appears in
   drivers/media/media-device.c: In function '__media_device_usb_init':
   drivers/media/media-device.c:870:25: error: 'LINUX_VERSION_CODE' undeclared (first use in this function)
     mdev->driver_version = LINUX_VERSION_CODE;
                            ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/KERNEL_VERSION +32 include/uapi/linux/media.h

b3b7a9f1 include/uapi/linux/media.h Mauro Carvalho Chehab 2015-12-11  26  #ifndef __KERNEL__
b3b7a9f1 include/uapi/linux/media.h Mauro Carvalho Chehab 2015-12-11  27  #include <stdint.h>
b3b7a9f1 include/uapi/linux/media.h Mauro Carvalho Chehab 2015-12-11  28  #endif
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18  29  #include <linux/ioctl.h>
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18  30  #include <linux/types.h>
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18  31  
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18 @32  #define MEDIA_API_VERSION	KERNEL_VERSION(0, 1, 0)
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18  33  
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18  34  struct media_device_info {
140d8816 include/linux/media.h      Laurent Pinchart      2010-08-18  35  	char driver[16];

:::::: The code at line 32 was first introduced by commit
:::::: 140d88165c25137e871f9559e67986ed89251105 [media] media: Media device information query

:::::: TO: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
kernel test robot Feb. 2, 2017, 3:27 p.m. UTC | #2
Hi Nicolas,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.10-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/uapi-export-all-headers-under-uapi-directories/20170202-213944
config: x86_64-randconfig-n0-02022216 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/media/media-device.c: In function 'media_device_get_info':
>> drivers/media/media-device.c:76:2: error: implicit declaration of function 'KERNEL_VERSION' [-Werror=implicit-function-declaration]
     info->media_version = MEDIA_API_VERSION;
     ^
   drivers/media/media-device.c: In function 'media_device_pci_init':
   drivers/media/media-device.c:841:25: error: 'LINUX_VERSION_CODE' undeclared (first use in this function)
     mdev->driver_version = LINUX_VERSION_CODE;
                            ^
   drivers/media/media-device.c:841:25: note: each undeclared identifier is reported only once for each function it appears in
   drivers/media/media-device.c: In function '__media_device_usb_init':
   drivers/media/media-device.c:870:25: error: 'LINUX_VERSION_CODE' undeclared (first use in this function)
     mdev->driver_version = LINUX_VERSION_CODE;
                            ^
   cc1: some warnings being treated as errors

vim +/KERNEL_VERSION +76 drivers/media/media-device.c

bcd5081b Sakari Ailus          2016-05-03  70  			sizeof(info->driver));
bb07bd6b Mauro Carvalho Chehab 2016-02-11  71  
bcd5081b Sakari Ailus          2016-05-03  72  	strlcpy(info->model, dev->model, sizeof(info->model));
bcd5081b Sakari Ailus          2016-05-03  73  	strlcpy(info->serial, dev->serial, sizeof(info->serial));
bcd5081b Sakari Ailus          2016-05-03  74  	strlcpy(info->bus_info, dev->bus_info, sizeof(info->bus_info));
140d8816 Laurent Pinchart      2010-08-18  75  
bcd5081b Sakari Ailus          2016-05-03 @76  	info->media_version = MEDIA_API_VERSION;
bcd5081b Sakari Ailus          2016-05-03  77  	info->hw_revision = dev->hw_revision;
bcd5081b Sakari Ailus          2016-05-03  78  	info->driver_version = dev->driver_version;
140d8816 Laurent Pinchart      2010-08-18  79  

:::::: The code at line 76 was first introduced by commit
:::::: bcd5081b05367d108c1380369c698a4601c41cfc [media] media: Refactor copying IOCTL arguments from and to user space

:::::: TO: Sakari Ailus <sakari.ailus@linux.intel.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/include/uapi/linux/bcache.h b/include/uapi/linux/bcache.h
index 22b6ad31c706..e3bb0635e94a 100644
--- a/include/uapi/linux/bcache.h
+++ b/include/uapi/linux/bcache.h
@@ -5,7 +5,7 @@ 
  * Bcache on disk data structures
  */
 
-#include <asm/types.h>
+#include <linux/types.h>
 
 #define BITMASK(name, type, field, offset, size)		\
 static inline __u64 name(const type *k)				\
diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
index d5ad15a106a7..6a261cb52d95 100644
--- a/include/uapi/linux/btrfs_tree.h
+++ b/include/uapi/linux/btrfs_tree.h
@@ -1,6 +1,8 @@ 
 #ifndef _BTRFS_CTREE_H_
 #define _BTRFS_CTREE_H_
 
+#include <linux/types.h>
+
 /*
  * This header contains the structure definitions and constants used
  * by file system objects that can be retrieved using
diff --git a/include/uapi/linux/cryptouser.h b/include/uapi/linux/cryptouser.h
index 11d21fce14d6..c6a09c5261e7 100644
--- a/include/uapi/linux/cryptouser.h
+++ b/include/uapi/linux/cryptouser.h
@@ -18,6 +18,8 @@ 
  * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include <linux/types.h>
+
 /* Netlink configuration messages.  */
 enum {
 	CRYPTO_MSG_BASE = 0x10,
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index 4890787731b8..27c972903b3f 100644
--- a/include/uapi/linux/media.h
+++ b/include/uapi/linux/media.h
@@ -28,7 +28,6 @@ 
 #endif
 #include <linux/ioctl.h>
 #include <linux/types.h>
-#include <linux/version.h>
 
 #define MEDIA_API_VERSION	KERNEL_VERSION(0, 1, 0)
 
diff --git a/include/uapi/linux/pr.h b/include/uapi/linux/pr.h
index 57d7c0f916b6..645ef3cf3dd0 100644
--- a/include/uapi/linux/pr.h
+++ b/include/uapi/linux/pr.h
@@ -1,6 +1,8 @@ 
 #ifndef _UAPI_PR_H
 #define _UAPI_PR_H
 
+#include <linux/types.h>
+
 enum pr_type {
 	PR_WRITE_EXCLUSIVE		= 1,
 	PR_EXCLUSIVE_ACCESS		= 2,
diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
index c396a8052f73..33496595064c 100644
--- a/include/uapi/linux/seg6.h
+++ b/include/uapi/linux/seg6.h
@@ -14,6 +14,8 @@ 
 #ifndef _UAPI_LINUX_SEG6_H
 #define _UAPI_LINUX_SEG6_H
 
+#include <linux/types.h>
+
 /*
  * SRH
  */