| Message ID | 1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Nicolas, 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > This header file is exported, thus move it to uapi. > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > -#endif /* __ASM_H8300_BITS_PER_LONG */ > diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h > new file mode 100644 > index 000000000000..e56cf72369b6 > --- /dev/null > +++ b/arch/h8300/include/uapi/asm/bitsperlong.h > @@ -0,0 +1,14 @@ > +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG > +#define _UAPI_ASM_H8300_BITS_PER_LONG Just a minor comment. The include guard was originally __ASM_H8300_BITS_PER_LONG. This will change it into _ASM_H8300_BITS_PER_LONG (after _UAPI is stripped by headers_install.sh) I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer, but I know I am nit-picking. I can apply this as-is. I leave it to you.
Le 27/03/2017 à 07:31, Masahiro Yamada a écrit : [snip] >> -#endif /* __ASM_H8300_BITS_PER_LONG */ >> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h >> new file mode 100644 >> index 000000000000..e56cf72369b6 >> --- /dev/null >> +++ b/arch/h8300/include/uapi/asm/bitsperlong.h >> @@ -0,0 +1,14 @@ >> +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG >> +#define _UAPI_ASM_H8300_BITS_PER_LONG > > > Just a minor comment. > > The include guard was originally __ASM_H8300_BITS_PER_LONG. > This will change it into _ASM_H8300_BITS_PER_LONG > (after _UAPI is stripped by headers_install.sh) > > I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer, > but I know I am nit-picking. I can apply this as-is. > I leave it to you. I intentionnaly "clean" that, but I will restore it, no problem ;-) Regards, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/h8300/include/asm/bitsperlong.h b/arch/h8300/include/asm/bitsperlong.h deleted file mode 100644 index e140e46729ac..000000000000 --- a/arch/h8300/include/asm/bitsperlong.h +++ /dev/null @@ -1,14 +0,0 @@ -#ifndef __ASM_H8300_BITS_PER_LONG -#define __ASM_H8300_BITS_PER_LONG - -#include <asm-generic/bitsperlong.h> - -#if !defined(__ASSEMBLY__) -/* h8300-unknown-linux required long */ -#define __kernel_size_t __kernel_size_t -typedef unsigned long __kernel_size_t; -typedef long __kernel_ssize_t; -typedef long __kernel_ptrdiff_t; -#endif - -#endif /* __ASM_H8300_BITS_PER_LONG */ diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h new file mode 100644 index 000000000000..e56cf72369b6 --- /dev/null +++ b/arch/h8300/include/uapi/asm/bitsperlong.h @@ -0,0 +1,14 @@ +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG +#define _UAPI_ASM_H8300_BITS_PER_LONG + +#include <asm-generic/bitsperlong.h> + +#if !defined(__ASSEMBLY__) +/* h8300-unknown-linux required long */ +#define __kernel_size_t __kernel_size_t +typedef unsigned long __kernel_size_t; +typedef long __kernel_ssize_t; +typedef long __kernel_ptrdiff_t; +#endif + +#endif /* _UAPI_ASM_H8300_BITS_PER_LONG */
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- arch/h8300/include/asm/bitsperlong.h | 14 -------------- arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 14 deletions(-) delete mode 100644 arch/h8300/include/asm/bitsperlong.h create mode 100644 arch/h8300/include/uapi/asm/bitsperlong.h