| Message ID | 1519776926-30459-6-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Feb 28, 2018 at 09:15:25AM +0900, Masahiro Yamada wrote: > The purpose of local{yes,mod}config is to arrange the .config file > based on actually loaded modules. It is unnecessary to update > include/generated/autoconf.h and include/config/* stuff here. > > They will be automatically updated during the build. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v2: > - newly added > > scripts/kconfig/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index c5d1d1a..bf9289a 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -49,11 +49,11 @@ localyesconfig localmodconfig: $(obj)/streamline_config.pl $(obj)/conf (Unrelated: $(obj)/streamline_config.pl is a checked-in file, so I wonder if there's any point to having it as a prerequisite of the phony targets local{yes,mod}config.) > cmp -s .tmp.config .config || \ > (mv -f .config .config.old.1; \ > mv -f .tmp.config .config; \ > - $(obj)/conf $(silent) --silentoldconfig $(Kconfig); \ > + $(obj)/conf $(silent) --oldconfig $(Kconfig); \ Maybe add extra space to keep \ aligned. > mv -f .config.old.1 .config.old) \ > else \ > mv -f .tmp.config .config; \ > - $(obj)/conf $(silent) --silentoldconfig $(Kconfig); \ > + $(obj)/conf $(silent) --oldconfig $(Kconfig); \ Ditto here. > fi > $(Q)rm -f .tmp.config > > -- > 2.7.4 > I'm not an expert on the Makefiles, but seems reasonable to me. Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com> Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2018-02-28 14:15 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: > On Wed, Feb 28, 2018 at 09:15:25AM +0900, Masahiro Yamada wrote: >> The purpose of local{yes,mod}config is to arrange the .config file >> based on actually loaded modules. It is unnecessary to update >> include/generated/autoconf.h and include/config/* stuff here. >> >> They will be automatically updated during the build. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> --- >> >> Changes in v2: >> - newly added >> >> scripts/kconfig/Makefile | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile >> index c5d1d1a..bf9289a 100644 >> --- a/scripts/kconfig/Makefile >> +++ b/scripts/kconfig/Makefile >> @@ -49,11 +49,11 @@ localyesconfig localmodconfig: $(obj)/streamline_config.pl $(obj)/conf > > (Unrelated: $(obj)/streamline_config.pl is a checked-in file, so I > wonder if there's any point to having it as a prerequisite of the phony > targets local{yes,mod}config.) > Indeed. It it unrelated, but I think it is worth fixing. Care to send a patch, please?
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index c5d1d1a..bf9289a 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -49,11 +49,11 @@ localyesconfig localmodconfig: $(obj)/streamline_config.pl $(obj)/conf cmp -s .tmp.config .config || \ (mv -f .config .config.old.1; \ mv -f .tmp.config .config; \ - $(obj)/conf $(silent) --silentoldconfig $(Kconfig); \ + $(obj)/conf $(silent) --oldconfig $(Kconfig); \ mv -f .config.old.1 .config.old) \ else \ mv -f .tmp.config .config; \ - $(obj)/conf $(silent) --silentoldconfig $(Kconfig); \ + $(obj)/conf $(silent) --oldconfig $(Kconfig); \ fi $(Q)rm -f .tmp.config
The purpose of local{yes,mod}config is to arrange the .config file based on actually loaded modules. It is unnecessary to update include/generated/autoconf.h and include/config/* stuff here. They will be automatically updated during the build. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v2: - newly added scripts/kconfig/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)