From patchwork Fri Mar 16 07:37:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 10286557 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AEFB460386 for ; Fri, 16 Mar 2018 07:39:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9BD7928D58 for ; Fri, 16 Mar 2018 07:39:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8FFEF28DA6; Fri, 16 Mar 2018 07:39:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 396FA28D58 for ; Fri, 16 Mar 2018 07:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbeCPHhq (ORCPT ); Fri, 16 Mar 2018 03:37:46 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:20645 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbeCPHhn (ORCPT ); Fri, 16 Mar 2018 03:37:43 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id w2G7bOa5029139; Fri, 16 Mar 2018 16:37:26 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w2G7bOa5029139 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1521185847; bh=hhhDa6mfh8jXfnRUfhSOjXjk5xwYiE0cRBQ5+bl0C38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GLdp3mTNLbYCirJhnE2uFiz/RUWVNnlgkgTJwl+qbEjWyqOaKs17JV05Dx5pnG7zv uBj+eoNgBtyBxwdrS5wgUznGnUd8BQ8cv5Oo7NLQTfsPnVqxZlawksnpo51A9W/67n rN0/ivo4YZDR6idkjuSnRIKvEPe3BaNnCZloMsyoX5MXGbgiT/IIhX4zpfML0gJgnM qGtvcHsj0eMmds/3+rP1+IpSyXNAeYsNyOkXTyXarcxmIBew2/LZt36W8ybgdpEXWg sFosmanVwrTsSQpf1hfd/CayeScMzFzPSdoE3nE/oihCT89E+hnxzn8xNCngTLaBNL JlUe/N02tZnOw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Michal Marek , Nicolas Pitre , linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH v4 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh Date: Fri, 16 Mar 2018 16:37:10 +0900 Message-Id: <1521185836-19120-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521185836-19120-1-git-send-email-yamada.masahiro@socionext.com> References: <1521185836-19120-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The comment mentions it creates autoksyms.h in case it is missing, but the actual code touches it when it does exists. The build system creates it anyway because and need it. The code would not have worked as intended, and people have not noticed it. This is a proof that we can simply remove it. Signed-off-by: Masahiro Yamada Acked-by: Nicolas Pitre --- Changes in v4: None Changes in v3: None Changes in v2: - Remove the code instead of fixing it scripts/adjust_autoksyms.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh index a162258..e0dd0d5 100755 --- a/scripts/adjust_autoksyms.sh +++ b/scripts/adjust_autoksyms.sh @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in . "./${KCONFIG_CONFIG}" esac -# In case it doesn't exist yet... -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi - # Generate a new ksym list file with symbols needed by the current # set of modules. cat > "$new_ksyms_file" << EOT