From patchwork Sat Jun 23 13:56:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 10483637 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 088A5601C8 for ; Sat, 23 Jun 2018 13:58:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1129F28429 for ; Sat, 23 Jun 2018 13:58:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0610D28717; Sat, 23 Jun 2018 13:58:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B77028429 for ; Sat, 23 Jun 2018 13:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbeFWN6P (ORCPT ); Sat, 23 Jun 2018 09:58:15 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:44605 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbeFWN6N (ORCPT ); Sat, 23 Jun 2018 09:58:13 -0400 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-08.nifty.com with ESMTP id w5NDvYBU015690; Sat, 23 Jun 2018 22:57:35 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w5NDvYBU015690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1529762255; bh=v6NARSvF1UqBTvB6pr8gmxA1bLYv2eXXGO7gcMxQNZ0=; h=From:To:Cc:Subject:Date:From; b=1Iaqp/EVhNjHBgpUr4UWufcGiyqjvj7AuPsqZOYTZVQmx41NulFOS/LwfKjEaHgun wV2rNuDFF7Pa86FFiNwtL34vDqEVrdwj1wOLyG9B+Q/mgI/Mg86hibtvQlgzQd6BVp 8BB9erTO71djodbIx3IlcIzSAZX03MnexbcMzpGn1UigpTaJ9oPPRU28mGRj7Kv/36 DAJRSMMV0vKdu2uHnGH8qrw9R71aAaAOxPUKuKNuZEA4OD3bh8nUX/igFHiMibDM5D cTnGzRpMVlvrs3xGT534uES8xIqlyhhV+ndeItVgTiUuPmCDLWMyGIQDustn1HX6+j SfNh+Wvo6tPlA== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] kbuild: use 'include' directive to load auto.conf from top Makefile Date: Sat, 23 Jun 2018 22:56:07 +0900 Message-Id: <1529762169-13488-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used. If a necessary configuration file is missing for the external module building, the following error message is displayed: ERROR: Kernel configuration is invalid. include/generated/autoconf.h or include/config/auto.conf are missing. Run 'make oldconfig && make prepare' on kernel src to fix it. However, Make still continues building; /bin/false let the creation of 'include/config/auto.config' fail, but Make can ignore the error since it is included by the '-include' directive. Use the 'include' directive instead. This allows the /bin/false to correctly terminate the whole build process. Signed-off-by: Masahiro Yamada --- Changes in v2: - New patch Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ca2af1a..413c2ed 100644 --- a/Makefile +++ b/Makefile @@ -589,7 +589,7 @@ virt-y := virt/ endif # KBUILD_EXTMOD ifeq ($(dot-config),1) --include include/config/auto.conf +include include/config/auto.conf endif # The all: target is the default when no target is given on the