| Message ID | 1534178919-8375-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] kconfig: remove unused sym_get_env_prop() function | expand |
On Tue, Aug 14, 2018 at 01:48:38AM +0900, Masahiro Yamada wrote: > This function is unused since commit 104daea149c4 ("kconfig: reference > environment variables directly and remove 'option env='"). > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Both patches are obviously correct. Feel free to add: Acked-by: Sam Ravnborg <sam@ravnborg.org> and apply to kbuild so we can get them in this cycle. Sam
2018-08-14 2:20 GMT+09:00 Sam Ravnborg <sam@ravnborg.org>: > On Tue, Aug 14, 2018 at 01:48:38AM +0900, Masahiro Yamada wrote: >> This function is unused since commit 104daea149c4 ("kconfig: reference >> environment variables directly and remove 'option env='"). >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Both patches are obviously correct. > Feel free to add: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > and apply to kbuild so we can get them in this cycle. > > Sam Applied to linux-kbuild/kconfig with Sam's Ack.
diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h index 6b7bbc6..9eb7c83 100644 --- a/scripts/kconfig/lkc.h +++ b/scripts/kconfig/lkc.h @@ -125,7 +125,6 @@ const char *sym_get_string_default(struct symbol *sym); struct symbol *sym_check_deps(struct symbol *sym); struct property *prop_alloc(enum prop_type type, struct symbol *sym); struct symbol *prop_get_symbol(struct property *prop); -struct property *sym_get_env_prop(struct symbol *sym); static inline tristate sym_get_tristate_value(struct symbol *sym) { diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c index 869a5e8..073d780 100644 --- a/scripts/kconfig/symbol.c +++ b/scripts/kconfig/symbol.c @@ -76,15 +76,6 @@ struct property *sym_get_choice_prop(struct symbol *sym) return NULL; } -struct property *sym_get_env_prop(struct symbol *sym) -{ - struct property *prop; - - for_all_properties(sym, prop, P_ENV) - return prop; - return NULL; -} - static struct property *sym_get_default_prop(struct symbol *sym) { struct property *prop;
This function is unused since commit 104daea149c4 ("kconfig: reference environment variables directly and remove 'option env='"). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/kconfig/lkc.h | 1 - scripts/kconfig/symbol.c | 9 --------- 2 files changed, 10 deletions(-)