| Message ID | 1552049064-32044-5-git-send-email-info@metux.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/5] Makefile: rules for printing kernel architecture and localversion | expand |
On Fri, 2019-03-08 at 13:44 +0100, Enrico Weigelt, metux IT consult wrote: > checkpatch.pl complains when adding executable "debian/rules", > obviously a false alarm. Therefore add an exception for that. This is predicated on a debian/ directory actually being added to the generic kernel tree. I'm not sure that's a good idea. As debian/ does not currently exist in the generic kernel source, I think this can be kept locally in their tree if they choose. > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2576,6 +2576,7 @@ sub process { > if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { > my $permhere = $here . "FILE: $realfile\n"; > if ($realfile !~ m@scripts/@ && > + $realfile !~ "debian/rules" && > $realfile !~ /\.(py|pl|awk|sh)$/) { > ERROR("EXECUTE_PERMISSIONS", > "do not set execute permissions for source files\n" . $permhere);
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b737ca9..7bcc70a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2576,6 +2576,7 @@ sub process { if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { my $permhere = $here . "FILE: $realfile\n"; if ($realfile !~ m@scripts/@ && + $realfile !~ "debian/rules" && $realfile !~ /\.(py|pl|awk|sh)$/) { ERROR("EXECUTE_PERMISSIONS", "do not set execute permissions for source files\n" . $permhere);
checkpatch.pl complains when adding executable "debian/rules", obviously a false alarm. Therefore add an exception for that. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)