diff mbox series

Documentation/Kbuild: Remove references to gcc-plugin.sh

Message ID 1611338653-175404-1-git-send-email-r.karszniewicz@phytec.de (mailing list archive)
State New
Headers show
Series Documentation/Kbuild: Remove references to gcc-plugin.sh | expand

Commit Message

Robert Karszniewicz Jan. 22, 2021, 6:04 p.m. UTC
gcc-plugin.sh has been removed in commit
1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").

Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
 Documentation/kbuild/gcc-plugins.rst |  6 ------
 scripts/dummy-tools/gcc              | 15 ---------------
 2 files changed, 21 deletions(-)

Comments

Kees Cook Jan. 22, 2021, 7:23 p.m. UTC | #1
On Fri, Jan 22, 2021 at 07:04:13PM +0100, Robert Karszniewicz wrote:
> gcc-plugin.sh has been removed in commit
> 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
> 
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>
Masahiro Yamada Jan. 23, 2021, 1:17 p.m. UTC | #2
On Sat, Jan 23, 2021 at 3:19 AM Robert Karszniewicz
<r.karszniewicz@phytec.de> wrote:
>
> gcc-plugin.sh has been removed in commit
> 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> ---
>  Documentation/kbuild/gcc-plugins.rst |  6 ------
>  scripts/dummy-tools/gcc              | 15 ---------------
>  2 files changed, 21 deletions(-)
>
> diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst
> index 4b1c10f88e30..63379d0150e3 100644
> --- a/Documentation/kbuild/gcc-plugins.rst
> +++ b/Documentation/kbuild/gcc-plugins.rst
> @@ -47,12 +47,6 @@ Files
>         This is a compatibility header for GCC plugins.
>         It should be always included instead of individual gcc headers.
>
> -**$(src)/scripts/gcc-plugin.sh**
> -
> -       This script checks the availability of the included headers in
> -       gcc-common.h and chooses the proper host compiler to build the plugins
> -       (gcc-4.7 can be built by either gcc or g++).
> -
>  **$(src)/scripts/gcc-plugins/gcc-generate-gimple-pass.h,
>  $(src)/scripts/gcc-plugins/gcc-generate-ipa-pass.h,
>  $(src)/scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h,
> diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> index 33487e99d83e..a484de576e6f 100755
> --- a/scripts/dummy-tools/gcc
> +++ b/scripts/dummy-tools/gcc
> @@ -74,18 +74,3 @@ if arg_contain -S "$@"; then
>                 exit 0
>         fi
>  fi
> -
> -# For scripts/gcc-plugin.sh
> -if arg_contain -print-file-name=plugin "$@"; then
> -       plugin_dir=$(mktemp -d)
> -
> -       sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
> -       while read header
> -       do
> -               mkdir -p $plugin_dir/include/$(dirname $header)
> -               touch $plugin_dir/include/$header
> -       done
> -
> -       echo $plugin_dir
> -       exit 0
> -fi


Well, it is wrong to remove this hunk entirely.
It would break the ability to enable GCC_PLUGINS.

I will simplify this part.
https://lore.kernel.org/patchwork/patch/1369968/


I took the only change to Documentation/kbuild/gcc-plugins.rst
from your patch but this document contains more stale info.

https://lore.kernel.org/patchwork/patch/1370008/
Robert Karszniewicz Jan. 23, 2021, 4:40 p.m. UTC | #3
On Sat, Jan 23, 2021 at 10:17:59PM +0900, Masahiro Yamada wrote:
> On Sat, Jan 23, 2021 at 3:19 AM Robert Karszniewicz
> <r.karszniewicz@phytec.de> wrote:
> >
> > gcc-plugin.sh has been removed in commit
> > 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
> >
> > Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> > ---
> >  Documentation/kbuild/gcc-plugins.rst |  6 ------
> >  scripts/dummy-tools/gcc              | 15 ---------------
> >  2 files changed, 21 deletions(-)
> >
> > [...]
> > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> > index 33487e99d83e..a484de576e6f 100755
> > --- a/scripts/dummy-tools/gcc
> > +++ b/scripts/dummy-tools/gcc
> > @@ -74,18 +74,3 @@ if arg_contain -S "$@"; then
> >                 exit 0
> >         fi
> >  fi
> > -
> > -# For scripts/gcc-plugin.sh
> > -if arg_contain -print-file-name=plugin "$@"; then
> > -       plugin_dir=$(mktemp -d)
> > -
> > -       sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
> > -       while read header
> > -       do
> > -               mkdir -p $plugin_dir/include/$(dirname $header)
> > -               touch $plugin_dir/include/$header
> > -       done
> > -
> > -       echo $plugin_dir
> > -       exit 0
> > -fi
> 
> 
> Well, it is wrong to remove this hunk entirely.
> It would break the ability to enable GCC_PLUGINS.
> 
> I will simplify this part.
> https://lore.kernel.org/patchwork/patch/1369968/
> 
> 
> I took the only change to Documentation/kbuild/gcc-plugins.rst
> from your patch but this document contains more stale info.
> 
> https://lore.kernel.org/patchwork/patch/1370008/

I see, thanks for letting me know,

Robert
diff mbox series

Patch

diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst
index 4b1c10f88e30..63379d0150e3 100644
--- a/Documentation/kbuild/gcc-plugins.rst
+++ b/Documentation/kbuild/gcc-plugins.rst
@@ -47,12 +47,6 @@  Files
 	This is a compatibility header for GCC plugins.
 	It should be always included instead of individual gcc headers.
 
-**$(src)/scripts/gcc-plugin.sh**
-
-	This script checks the availability of the included headers in
-	gcc-common.h and chooses the proper host compiler to build the plugins
-	(gcc-4.7 can be built by either gcc or g++).
-
 **$(src)/scripts/gcc-plugins/gcc-generate-gimple-pass.h,
 $(src)/scripts/gcc-plugins/gcc-generate-ipa-pass.h,
 $(src)/scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h,
diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
index 33487e99d83e..a484de576e6f 100755
--- a/scripts/dummy-tools/gcc
+++ b/scripts/dummy-tools/gcc
@@ -74,18 +74,3 @@  if arg_contain -S "$@"; then
 		exit 0
 	fi
 fi
-
-# For scripts/gcc-plugin.sh
-if arg_contain -print-file-name=plugin "$@"; then
-	plugin_dir=$(mktemp -d)
-
-	sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
-	while read header
-	do
-		mkdir -p $plugin_dir/include/$(dirname $header)
-		touch $plugin_dir/include/$header
-	done
-
-	echo $plugin_dir
-	exit 0
-fi