| Message ID | 200904012143.18562.elendil@planet.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 01 Apr 2009, Frans Pop wrote: > The Debian packaging scripts created by the deb-pkg target do not pass > on the standard Debian maintainer script parameters to hook scripts, > which means that those scripts cannot tell whether they are being called > during e.g. install vs. upgrade, or removal vs. purge of the package. > > As there are several variantions in how hook scripts are called from > kernel packages, we pass the parameters in the environment variable > DEB_MAINT_PARAMS rather than as extra arguments. > > Bump version of builddep script to 1.3. > > Signed-off-by: Frans Pop <elendil@planet.nl> ack for the env variable. > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > index 5b1517d..c9a4dcd 100644 > --- a/scripts/package/builddeb > +++ b/scripts/package/builddeb > @@ -1,6 +1,6 @@ > #!/bin/sh > # > -# builddeb 1.2 > +# builddeb 1.3 > # Copyright 2003 Wichert Akkerman <wichert@wiggy.net> > # > # Simple script to generate a deb package for a Linux kernel. All the > @@ -63,7 +63,11 @@ for script in postinst postrm preinst prerm ; do > > set -e > > -test -d /etc/kernel/$script.d && run-parts --arg="$version" /etc/kernel/$script.d > +# Pass maintainer script parameters to hook scripts > +export DEB_MAINT_PARAMS="\$@" > + > +test -d $debhookdir/$script.d && \\ > + run-parts --arg="$version" /etc/kernel/$script.d gratious formating change, please if this needs to be broken in 2 lines, break before && so that logic is more evident. > exit 0 > EOF > chmod 755 "$tmpdir/DEBIAN/$script" > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 5b1517d..c9a4dcd 100644 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -1,6 +1,6 @@ #!/bin/sh # -# builddeb 1.2 +# builddeb 1.3 # Copyright 2003 Wichert Akkerman <wichert@wiggy.net> # # Simple script to generate a deb package for a Linux kernel. All the @@ -63,7 +63,11 @@ for script in postinst postrm preinst prerm ; do set -e -test -d /etc/kernel/$script.d && run-parts --arg="$version" /etc/kernel/$script.d +# Pass maintainer script parameters to hook scripts +export DEB_MAINT_PARAMS="\$@" + +test -d $debhookdir/$script.d && \\ + run-parts --arg="$version" /etc/kernel/$script.d exit 0 EOF chmod 755 "$tmpdir/DEBIAN/$script"
The Debian packaging scripts created by the deb-pkg target do not pass on the standard Debian maintainer script parameters to hook scripts, which means that those scripts cannot tell whether they are being called during e.g. install vs. upgrade, or removal vs. purge of the package. As there are several variantions in how hook scripts are called from kernel packages, we pass the parameters in the environment variable DEB_MAINT_PARAMS rather than as extra arguments. Bump version of builddep script to 1.3. Signed-off-by: Frans Pop <elendil@planet.nl> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html