From patchwork Sun May 17 15:56:17 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Helt X-Patchwork-Id: 24332 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4HFoFX4013657 for ; Sun, 17 May 2009 15:50:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbZEQPuM (ORCPT ); Sun, 17 May 2009 11:50:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752040AbZEQPuM (ORCPT ); Sun, 17 May 2009 11:50:12 -0400 Received: from mx1.wp.pl ([212.77.101.5]:31440 "EHLO mx1.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbZEQPuK (ORCPT ); Sun, 17 May 2009 11:50:10 -0400 Received: (wp-smtpd smtp.wp.pl 29963 invoked from network); 17 May 2009 17:50:09 +0200 Received: from 93-181-133-4.as.kn.pl (HELO krzysio.net) (krzysztof.h1@[93.181.133.4]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with SMTP for ; 17 May 2009 17:50:09 +0200 Date: Sun, 17 May 2009 17:56:17 +0200 From: Krzysztof Helt To: linux-kbuild@vger.kernel.org Cc: LKLM Subject: Kconfig: fix problem in HID menu Message-Id: <20090517175617.81323cc1.krzysztof.h1@wp.pl> X-Mailer: Sylpheed 2.4.3 (GTK+ 2.11.0; i686-pc-linux-gnu) Mime-Version: 1.0 X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [EYM0] Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org From: Krzysztof Helt Following syntax does not work properly if there is an options FOO2 depending on the FOO: config FOO tristate "Foo" if EMBEDDED depends on FUD default !EMBEDDED config FOO2 bool "Foo2" depends on FOO If the EMBEDDED is not selected the FOO option is selected and it cannot be unselected. The change of the FOO definition: config FOO tristate "Foo" depends on EMBEDDED && FUD default !EMBEDDED fixes the issue. This is likely a bug in Kconfig tool. Signed-off-by: Krzysztof Helt --- -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 7e67dcb..c52204d 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -153,8 +153,8 @@ config HID_KENSINGTON Support for Kensington Slimblade Trackball. config HID_LOGITECH - tristate "Logitech" if EMBEDDED - depends on USB_HID + tristate "Logitech" + depends on EMBEDDED && USB_HID default !EMBEDDED ---help--- Support for Logitech devices that are not fully compliant with HID standard. @@ -205,8 +205,8 @@ config HID_NTRIG Support for N-Trig touch screen. config HID_PANTHERLORD - tristate "Pantherlord devices support" if EMBEDDED - depends on USB_HID + tristate "Pantherlord devices support" + depends on EMBEDDED && USB_HID default !EMBEDDED ---help--- Support for PantherLord/GreenAsia based device support.