From patchwork Fri Jun  5 02:12:01 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Amerigo Wang <amwang@redhat.com>
X-Patchwork-Id: 28053
Received: from vger.kernel.org (vger.kernel.org [209.132.176.167])
	by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n552CIQD002779
	for <patchwork-kbuild@patchwork.kernel.org>;
	Fri, 5 Jun 2009 02:12:19 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752505AbZFECMI (ORCPT
	<rfc822;patchwork-kbuild@patchwork.kernel.org>);
	Thu, 4 Jun 2009 22:12:08 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752296AbZFECMI
	(ORCPT <rfc822;linux-kbuild-outgoing>);
	Thu, 4 Jun 2009 22:12:08 -0400
Received: from mx2.redhat.com ([66.187.237.31]:60724 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751347AbZFECMH (ORCPT <rfc822;linux-kbuild@vger.kernel.org>);
	Thu, 4 Jun 2009 22:12:07 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com
	[172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n552C5xn029469;
	Thu, 4 Jun 2009 22:12:05 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id
	n552C33W006229; Thu, 4 Jun 2009 22:12:04 -0400
Received: from localhost.localdomain (dhcp-65-141.nay.redhat.com
	[10.66.65.141])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n552C1Jn014905;
	Thu, 4 Jun 2009 22:12:01 -0400
Date: Thu, 4 Jun 2009 22:12:01 -0400
From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, sam@ravnborg.org,
	Amerigo Wang <amwang@redhat.com>, linux-kbuild@vger.kernel.org
Message-Id: <20090605021419.7905.89870.sendpatchset@localhost.localdomain>
Subject: [Patch] kbuild: fix headers_check.pl
X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26
Sender: linux-kbuild-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kbuild.vger.kernel.org>
X-Mailing-List: linux-kbuild@vger.kernel.org

'extern' checking information is not clear, refine it.
Plus, fix a comment.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>

----
---
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
index 56f90a4..3923888 100644
--- a/scripts/headers_check.pl
+++ b/scripts/headers_check.pl
@@ -2,7 +2,7 @@
 #
 # headers_check.pl execute a number of trivial consistency checks
 #
-# Usage: headers_check.pl dir [files...]
+# Usage: headers_check.pl dir arch [files...]
 # dir:   dir to look for included files
 # arch:  architecture
 # files: list of files to check
@@ -37,7 +37,7 @@ foreach my $file (@files) {
 		&check_include();
 		&check_asm_types();
 		&check_sizetypes();
-		&check_prototypes();
+		&check_declarations();
 		# Dropped for now. Too much noise &check_config();
 	}
 	close FH;
@@ -61,10 +61,14 @@ sub check_include
 	}
 }
 
-sub check_prototypes
+sub check_declarations
 {
-	if ($line =~ m/^\s*extern\b/) {
-		printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
+	if ($line =~m/^\s*extern\b/) {
+		if ($line =~ m/^\s*extern\b.*\(.*\)/) {
+			printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
+		} else {
+			printf STDERR "$filename:$lineno: exporting global variable to userspace is suspicious\n";
+		}
 	}
 }