| Message ID | 20121021074016.GA2604@squish.home.loc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
(Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > Hi; > > In menuconfig, General setup -> IRQ subsystem, there are two > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > on MAY_HAVE_SPARSE_IRQ. > > On the x86-64 arch, neither of these seems to be set, so the > menu entry is blank if entered (displaying an odd ^@ if you try to > navigate up or down. And sometimes some screen garbage on the sides.) > > Previously (in the 3.2 kernel at least) this menu used to be > populated by the "Support sparse IRQ numbering" menu-item, which > at that time depended on HAVE_SPARSE_IRQ, and was forced to YES. > > I do not know if the current behaviour is intended, but it > is ugly and confusing to be confronted with a blank menu page. > > Ideally, the "IRQ subsystem" menu would not even show up > if it would contain no menu-items, but I do not know enough to > formulate that constraint. > > A simple alternative is a comment section to reasure babes in > the wood of kernel configuration that something is not amiss. I include > a sample patch. > > Paul > set.mailinglist@gmail.com > --- linux-3.7-rc2/kernel/irq/Kconfig.orig 2012-10-20 15:11:32.000000000 -0400 > +++ linux-3.7-rc2/kernel/irq/Kconfig 2012-10-21 03:14:56.272952813 -0400 > @@ -4,6 +4,9 @@ config HAVE_GENERIC_HARDIRQS > > if HAVE_GENERIC_HARDIRQS > menu "IRQ subsystem" > + > +comment "Some configurations may have no available options here" > + > # > # Interrupt subsystem related configuration options > # -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@suse.cz> wrote: > (Adding lkml and Thomas as IRQ subsystem maintainer to CC) > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > > Hi; > > > > In menuconfig, General setup -> IRQ subsystem, there are two > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > > on MAY_HAVE_SPARSE_IRQ. > > > > On the x86-64 arch, neither of these seems to be set, so the > > menu entry is blank if entered (displaying an odd ^@ if you try to > > navigate up or down. And sometimes some screen garbage on the sides.) > > > > Previously (in the 3.2 kernel at least) this menu used to be > > populated by the "Support sparse IRQ numbering" menu-item, which > > at that time depended on HAVE_SPARSE_IRQ, and was forced to YES. > > > > I do not know if the current behaviour is intended, but it > > is ugly and confusing to be confronted with a blank menu page. > > > > Ideally, the "IRQ subsystem" menu would not even show up > > if it would contain no menu-items, but I do not know enough to > > formulate that constraint. First, move the 'menu "IRQ subsystem"' line does to right before the IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right below the menu item. You'll also need to move the IRQ_FORCED_THREADING line out from inside the menu block. Try it out and let me know how it goes. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-3.7-rc2/kernel/irq/Kconfig.orig 2012-10-20 15:11:32.000000000 -0400 +++ linux-3.7-rc2/kernel/irq/Kconfig 2012-10-21 03:14:56.272952813 -0400 @@ -4,6 +4,9 @@ config HAVE_GENERIC_HARDIRQS if HAVE_GENERIC_HARDIRQS menu "IRQ subsystem" + +comment "Some configurations may have no available options here" + # # Interrupt subsystem related configuration options #