From patchwork Thu May 2 20:25:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 2513681 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id F2485DF215 for ; Thu, 2 May 2013 20:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758796Ab3EBU0B (ORCPT ); Thu, 2 May 2013 16:26:01 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:37836 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758644Ab3EBU0B (ORCPT ); Thu, 2 May 2013 16:26:01 -0400 Received: from merkur.ravnborg.org (unknown [188.228.89.252]) by smtp.domainteam.dk (Postfix) with ESMTPA id 39222F18E8; Thu, 2 May 2013 22:26:00 +0200 (CEST) Date: Thu, 2 May 2013 22:25:59 +0200 From: Sam Ravnborg To: Ian Kumlien Cc: linux-kbuild@vger.kernel.org, hpa@zytor.com, mmarek@suse.cz Subject: Re: Silent failure when missing bc Message-ID: <20130502202559.GA17647@merkur.ravnborg.org> References: <20130502144403.GE6335@pomac.netswarm.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130502144403.GE6335@pomac.netswarm.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Thu, May 02, 2013 at 04:44:03PM +0200, Ian Kumlien wrote: > Hi, > > A dependency on bc was added at some point during the 3.9 development. > > My machines runs a git forest which contains both stable and Torvalds > mainline. So any kernel version is only a: > git fetch --all && git checkout away > > When switching from v3.8.5 to v3.9-rc7 i ran in to a odd thing. > > It seemed to build fine, make install and modules_install was all fine > as well but rebooting revealed that 3.8.5 had been installed again > instead. > > Doing make clean and rebuilding revealed that I was missing bc ;) > > I have tried to find exactly where it's run since then, i have found the > cmd_bc section but not found what triggers it... Due to lack of time and > energy, I hearby report this bug! > > This is about as far as i got: > kernel/Makefile:135:quiet_cmd_bc = BC $@ > kernel/Makefile:136: cmd_bc = bc -q $(filter-out FORCE,$^) > $@ Could you try this patch. Untested but I think it required to catch this bug. > > Is there any detaled information and or instructions on kbuild btw? There is some docs in Documentation/kbuild/* - but I dunno if this is what you are after. Sam --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/Makefile b/kernel/Makefile index d1574d4..18a9083 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -134,7 +134,7 @@ $(obj)/hz.bc: $(objtree)/include/config/hz.h FORCE $(call if_changed,hzfile) quiet_cmd_bc = BC $@ - cmd_bc = bc -q $(filter-out FORCE,$^) > $@ + cmd_bc = bc -q $(filter-out FORCE,$^) > $@ || (rm -f $@; false) targets += timeconst.h $(obj)/timeconst.h: $(obj)/hz.bc $(src)/timeconst.bc FORCE