From patchwork Wed Jun 11 19:16:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 4338101 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C0DA59F314 for ; Wed, 11 Jun 2014 19:16:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EB76A20256 for ; Wed, 11 Jun 2014 19:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2215F20218 for ; Wed, 11 Jun 2014 19:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbaFKTQO (ORCPT ); Wed, 11 Jun 2014 15:16:14 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:37718 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbaFKTQO (ORCPT ); Wed, 11 Jun 2014 15:16:14 -0400 Received: from localhost (localhost [127.0.0.1]) by asavdk4.altibox.net (Postfix) with ESMTP id 2BF9F800B3; Wed, 11 Jun 2014 21:16:12 +0200 (CEST) Received: from asavdk4.altibox.net ([127.0.0.1]) by localhost (asavdk4.lysetele.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id g85oHj9ySS5w; Wed, 11 Jun 2014 21:16:11 +0200 (CEST) Received: from ravnborg.org (unknown [188.228.89.252]) (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 4D60D800B1; Wed, 11 Jun 2014 21:16:11 +0200 (CEST) Date: Wed, 11 Jun 2014 21:16:09 +0200 From: Sam Ravnborg To: Andy Lutomirski Cc: Josh Boyer , "H. Peter Anvin" , Michal Marek , "linux-kbuild@vger.kernel.org" , "Linux-Kernel@Vger. Kernel. Org" Subject: Re: [PATCH 2/2] x86,vdso: Fix vdso_install Message-ID: <20140611191609.GA16069@ravnborg.org> References: <5398749B.4090209@zytor.com> <20140611185119.GA13412@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > > > > Can we please fix this in a way where we do not need to add stuff to core kbuild. > > If the original approach was used then make took care of the looping > > and the foreach part was not needed. Following is my first quick approach. It reuses the old - a little complex logic to do the looping and copying. Thsi is only tested on my i386 box / build. Sam --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile index 9769df0..39fb152 100644 --- a/arch/x86/vdso/Makefile +++ b/arch/x86/vdso/Makefile @@ -9,11 +9,6 @@ VDSOX32-$(CONFIG_X86_X32_ABI) := y VDSO32-$(CONFIG_X86_32) := y VDSO32-$(CONFIG_COMPAT) := y -vdso-install-$(VDSO64-y) += vdso.so -vdso-install-$(VDSOX32-y) += vdsox32.so -vdso-install-$(VDSO32-y) += $(vdso32-images) - - # files to link into the vdso vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o @@ -179,12 +174,12 @@ GCOV_PROFILE := n # Install the unstripped copy of vdso*.so listed in $(vdso-install-y). # quiet_cmd_vdso_install = INSTALL $@ - cmd_vdso_install = cp $(obj)/$@.dbg $(MODLIB)/vdso/$@ -$(vdso-install-y): %.so: $(obj)/%.so.dbg FORCE + cmd_vdso_install = cp $(obj)/$@ $(MODLIB)/vdso/$(@:.dbg=) +$(vdso_img_sodbg): %.so.dbg: $(obj)/%.so.dbg FORCE @mkdir -p $(MODLIB)/vdso $(call cmd,vdso_install) -PHONY += vdso_install $(vdso-install-y) -vdso_install: $(vdso-install-y) +PHONY += vdso_install $(vdso_img_sodbg) +vdso_install: $(vdso_img_sodbg) clean-files := vdso32-syscall* vdso32-sysenter* vdso32-int80*