diff mbox

kbuild: make samples depend on headers_install

Message ID 20160704143949.2357806-1-arnd@arndb.de (mailing list archive)
State New, archived
Headers show

Commit Message

Arnd Bergmann July 4, 2016, 2:39 p.m. UTC
Olof's build test setup keeps failing to compile arm64 kernels
because of a toolchain that uses outdated kernel headers:

/work/build/batch/samples/seccomp/bpf-fancy.c:13:27: fatal error: linux/seccomp.h: No such file or directory

This is of course something he could change, but it also indicates
that others may run into the same problem. Running 'make headers_install'
avoids the issue by ensuring that the kernel headers are put into
the $(objdir)/usr/include path before we build the samples.

The same problem happened for the Documentation build in the
past and was fixed up with commit 8e2faea877eb ("Make Documenation
depend on headers_install"). This adds an identical Makefile dependency
for the samples/ subdirectory.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michal Marek July 22, 2016, 11:59 a.m. UTC | #1
On 2016-07-04 16:39, Arnd Bergmann wrote:
> Olof's build test setup keeps failing to compile arm64 kernels
> because of a toolchain that uses outdated kernel headers:
> 
> /work/build/batch/samples/seccomp/bpf-fancy.c:13:27: fatal error: linux/seccomp.h: No such file or directory
> 
> This is of course something he could change, but it also indicates
> that others may run into the same problem. Running 'make headers_install'
> avoids the issue by ensuring that the kernel headers are put into
> the $(objdir)/usr/include path before we build the samples.
> 
> The same problem happened for the Documentation build in the
> past and was fixed up with commit 8e2faea877eb ("Make Documenation
> depend on headers_install"). This adds an identical Makefile dependency
> for the samples/ subdirectory.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to kbuild.git#kbuild.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Makefile b/Makefile
index ec355167cf36..4a44055e3433 100644
--- a/Makefile
+++ b/Makefile
@@ -1633,7 +1633,7 @@  endif
 	$(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
 	$(build)=$(build-dir)
 # Make sure the latest headers are built for Documentation
-Documentation/: headers_install
+Documentation/ samples/: headers_install
 %/: prepare scripts FORCE
 	$(cmd_crmodverdir)
 	$(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \