From patchwork Wed Jul 13 22:34:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 9228595 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6761460572 for ; Wed, 13 Jul 2016 22:35:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5484A27F8F for ; Wed, 13 Jul 2016 22:35:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 474B827FB6; Wed, 13 Jul 2016 22:35:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACD5827F8F for ; Wed, 13 Jul 2016 22:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbcGMWfy (ORCPT ); Wed, 13 Jul 2016 18:35:54 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46372 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbcGMWfy (ORCPT ); Wed, 13 Jul 2016 18:35:54 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6DMYjFJ031393 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2016 22:34:45 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u6DMYhbO026612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2016 22:34:45 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u6DMYfbi027439; Wed, 13 Jul 2016 22:34:42 GMT Received: from mwanda (/154.0.139.178) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Jul 2016 15:34:40 -0700 Date: Thu, 14 Jul 2016 01:34:33 +0300 From: Dan Carpenter To: "Yann E. MORIN" , "Luis R. Rodriguez" Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Michal Marek Subject: [patch] kconfig: Add some missing curly braces Message-ID: <20160713223433.GA20475@mwanda> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are missing curly braces here so we print some stuff to stderr which we hadn't intended. Fixes: 1c199f2878f6 ('kbuild: document recursive dependency limitation / resolution') Signed-off-by: Dan Carpenter Acked-by: Luis R. Rodriguez --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c index 2432298..ff0feab 100644 --- a/scripts/kconfig/symbol.c +++ b/scripts/kconfig/symbol.c @@ -1127,11 +1127,12 @@ static void sym_check_print_recursive(struct symbol *last_sym) break; } } - if (stack->sym == last_sym) + if (stack->sym == last_sym) { fprintf(stderr, "%s:%d:error: recursive dependency detected!\n", prop->file->name, prop->lineno); fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n"); fprintf(stderr, "subsection \"Kconfig recursive dependency limitations\"\n"); + } if (stack->expr) { fprintf(stderr, "%s:%d:\tsymbol %s %s value contains %s\n", prop->file->name, prop->lineno,