From patchwork Tue Oct 18 00:16:26 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Adam Borowski <kilobyte@angband.pl>
X-Patchwork-Id: 9380911
Return-Path: <linux-kbuild-owner@kernel.org>
Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org
	[172.30.200.125])
	by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id
	DE743600CA for <patchwork-linux-kbuild@patchwork.kernel.org>;
	Tue, 18 Oct 2016 00:17:13 +0000 (UTC)
Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1])
	by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA56128325
	for <patchwork-linux-kbuild@patchwork.kernel.org>;
	Tue, 18 Oct 2016 00:17:13 +0000 (UTC)
Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486)
	id BEB7128FF0; Tue, 18 Oct 2016 00:17:13 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	pdx-wl-mail.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI
	autolearn=ham version=3.3.1
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D3D728325
	for <patchwork-linux-kbuild@patchwork.kernel.org>;
	Tue, 18 Oct 2016 00:17:12 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758906AbcJRARL (ORCPT
	<rfc822;patchwork-linux-kbuild@patchwork.kernel.org>);
	Mon, 17 Oct 2016 20:17:11 -0400
Received: from tartarus.angband.pl ([89.206.35.136]:39887 "EHLO
	tartarus.angband.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933002AbcJRAQl (ORCPT
	<rfc822;linux-kbuild@vger.kernel.org>);
	Mon, 17 Oct 2016 20:16:41 -0400
Received: from kilobyte by tartarus.angband.pl with local (Exim 4.84_2)
	(envelope-from <kilobyte@angband.pl>)
	id 1bwI4w-000235-LF; Tue, 18 Oct 2016 02:16:26 +0200
Date: Tue, 18 Oct 2016 02:16:26 +0200
From: Adam Borowski <kilobyte@angband.pl>
To: Mathieu OTHACEHE <m.othacehe@gmail.com>
Cc: Nicholas Piggin <npiggin@gmail.com>, Omar Sandoval <osandov@osandov.com>,
	Michal Marek <mmarek@suse.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	adobriyan@gmail.com, sfr@canb.auug.org.au, viro@zeniv.linux.org.uk,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org
Subject: Re: [GIT PULL] kbuild changes for v4.9-rc1
Message-ID: <20161018001626.GA5976@angband.pl>
References: <20161017100130.GA16013@angband.pl>
 <871szfb1x1.fsf@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <871szfb1x1.fsf@gmail.com>
X-Junkbait: aaron@angband.pl, zzyx@angband.pl
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: kilobyte@angband.pl
X-SA-Exim-Scanned: No (on tartarus.angband.pl);
	SAEximRunCond expanded to false
Sender: linux-kbuild-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kbuild.vger.kernel.org>
X-Mailing-List: linux-kbuild@vger.kernel.org
X-Virus-Scanned: ClamAV using ClamSMTP

On Mon, Oct 17, 2016 at 02:22:34PM +0200, Mathieu OTHACEHE wrote:
> > +#include <asm/uaccess.h>
> > +#include <asm/uaccess.h>
> 
> Included twice.

D'oh!

> > +#include <asm/string.h>
> > +#include <asm/page.h>
> > +#include <asm/checksum.h>
> > +
> > +#include <asm-generic/asm-prototypes.h>
> > +
> > +#include <asm/page.h>
> > +#include <asm/pgtable.h>
> > +#include <asm/special_insns.h>
> > +#include <asm/preempt.h>
> 
> No <asm/arch_hweight.h> for __sw_hweight32 and __sw_hweight64 ? 


Unless you guys prefer using low-level headers only, that is.


Meow!
Tested-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/include/asm-generic/asm-prototypes.h b/include/asm-generic/asm-prototypes.h
new file mode 100644
index 0000000..df13637
--- /dev/null
+++ b/include/asm-generic/asm-prototypes.h
@@ -0,0 +1,7 @@
+#include <linux/bitops.h>

... which has these.

Alexey Dobriyan <adobriyan@gmail.com> wrote:
} bitops.h is wrong header as well.
} Why do you need bitops for bunch of function prototypes?