From patchwork Tue Nov 8 01:33:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 9416329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 67A1F6048F for ; Tue, 8 Nov 2016 01:50:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 105DC28BF5 for ; Tue, 8 Nov 2016 01:50:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 02B5128E9F; Tue, 8 Nov 2016 01:50:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C06228BF5 for ; Tue, 8 Nov 2016 01:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbcKHBu2 (ORCPT ); Mon, 7 Nov 2016 20:50:28 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35826 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbcKHBu1 (ORCPT ); Mon, 7 Nov 2016 20:50:27 -0500 Received: by mail-pf0-f195.google.com with SMTP id i88so17587017pfk.2; Mon, 07 Nov 2016 17:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=H0CHSfAtWIpZSiCptYggFqk64/7oL1bySQHuweQjjlA=; b=klZk9aXTxtYHH86EDFoGHXWOxdLQwbGlfTSj66iuiJ2JAhi+NaDvwklXySCh2FwbrQ IUNUn12hfePJBjwhvxg9wMtMlwCZ+DakjJLZkk3lPg7vaTUoTOS2Hc1VIVWQEfdDEIXz GmSMDFvw2DfM5I9GoEU3LUFvrEM+EHklf824XntUugCtjwNJHwb4if/zQAS7RARMmTce j3lGQdT/J3ivkdUBIPGpx+W4Sin/+Dzq0GU01GgLukmTr4p05mOzYhO3ZZXtuC8vwefS mdNNUI3KPp8RPU+1dBNVo0WBNE+RB/O7L70cye30fChKJiEWpIcWtVsfji4s7cK+PFxM tQlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=H0CHSfAtWIpZSiCptYggFqk64/7oL1bySQHuweQjjlA=; b=Pc4zhXZKG1XzEd/KzDT1WFF8G0emc8qKPeGh1v96tYB3KGpXSxAcHJfSAEvkEJteqD LmHzo/rB9DhsnfO+/sw0RIoV331+sW8hGGnWUSsPvJJ2F5OxbatJUPxQ6K7A+VIop0Qz kpz82DP3HuMFu5NCJVMyHRLmAKKdabCLhuMAo95Y4bD0p8lOAbfvARlgw5Zm0mg8EL3a ZJL3oS7L3aqzim5RbrIgzNN64fMVLAbOBc5LMvDHm4pfiDaUy8UiFI+1GHwucqw1z/9X h418tcdrPgyoore1OjAOqsPql2iz4cQBM2opzOf77fLN1Vfcrhw4C6hOkaCAhiuNjMBO jRVg== X-Gm-Message-State: ABUngvdoAB/U8QftVJQJP2xLj2YOLM5m2lrYuPD9ebcV7Yf2a17QCMSwSWCM4PRsdYMM8g== X-Received: by 10.99.113.90 with SMTP id b26mr15036696pgn.33.1478568831765; Mon, 07 Nov 2016 17:33:51 -0800 (PST) Received: from roar.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id xg4sm43437591pac.39.2016.11.07.17.33.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Nov 2016 17:33:51 -0800 (PST) Date: Tue, 8 Nov 2016 12:33:34 +1100 From: Nicholas Piggin To: Peter Wu Cc: Vince Weaver , Michal Marek , Al Viro , Oliver Hartkopp , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: 'kbuild' merge before 4.9-rc1 breaks build and boot Message-ID: <20161108123334.3df2dcc9@roar.ozlabs.ibm.com> In-Reply-To: <20161107213907.GB18092@al> References: <4c04b846-3da8-dc42-4fa6-30f72a5c2437@hartkopp.net> <20161027154202.GE27017@al> <20161107213907.GB18092@al> Organization: IBM X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 7 Nov 2016 22:39:07 +0100 Peter Wu wrote: > On Mon, Nov 07, 2016 at 02:10:12PM -0500, Vince Weaver wrote: > > On Thu, 27 Oct 2016, Peter Wu wrote: > > > > > I can confirm Olivers issue, the current mainline kernel fails to boot > > > on kernels with CONFIG_MODVERSIONS=y. Bisection points to: > > > > > > commit 784d5699eddc55878627da20d3fe0c8542e2f1a2 > > > Author: Al Viro > > > Date: Mon Jan 11 11:04:34 2016 -0500 > > > > WARNING: "memset" [sound/usb/snd-usbmidi-lib.ko] has no CRC! > > > > WARNING: "__fentry__" [sound/usb/snd-usbmidi-lib.ko] has no CRC! > > > > WARNING: "memcpy" [sound/usb/snd-usbmidi-lib.ko] has no CRC! > > > > WARNING: "__sw_hweight32" [sound/usb/snd-usbmidi-lib.ko] has no CRC! > > > > Has any progress been made with this problem? > > > > I'm also encountering it on my debian-unstable box on any kernel more > > recent than 4.9-rc1 (up to and including 4.9-rc4). I am glad someone > > managed to isolate it as I was unable to get a clean bisect. > > > > Vince > > The original kbuild issue went in via > merge commit 84d69848c97faab0c25aa2667b273404d2e2a64a which notes: > > - EXPORT_SYMBOL for asm source by Al Viro. > > This does bring a regression, because genksyms no longer generates > checksums for these symbols (CONFIG_MODVERSIONS). Nick Piggin is > working on a patch to fix this. > > Plus, we are talking about functions like strcpy(), which rarely > change prototypes. > > Adding Nicholas in the cc, hopefully he can give a status update. I think Michal has everything needed now for the kbuild bits. The arch specific patches can go via arch trees quite easily (there is no hard dependency either way). This is the kbuild bit: https://git.kernel.org/cgit/linux/kernel/git/mmarek/kbuild.git/commit/?h=rc-fixes&id=4efca4ed05cbdfd13ec3e8cb623fb77d6e4ab187 And it also needs this incremental bit not in Michal's tree yet: --- scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 3e223c2..05c6bb4 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -332,7 +332,7 @@ cmd_gensymtypes_S = \ (echo "\#include " ; \ echo "\#include " ; \ $(CPP) $(a_flags) $< | \ - grep ^___EXPORT_SYMBOL | \ + grep ___EXPORT_SYMBOL | \ sed 's/___EXPORT_SYMBOL \([a-zA-Z0-9_]*\),.*/EXPORT_SYMBOL(\1);/' ) | \ $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | \ $(GENKSYMS) $(if $(1), -T $(2)) \