From patchwork Thu Jun 22 17:13:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9804983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EE74360329 for ; Thu, 22 Jun 2017 17:18:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D124A2621D for ; Thu, 22 Jun 2017 17:18:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5E61286B9; Thu, 22 Jun 2017 17:18:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72B7E2621D for ; Thu, 22 Jun 2017 17:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680AbdFVRRv (ORCPT ); Thu, 22 Jun 2017 13:17:51 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:51271 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbdFVROm (ORCPT ); Thu, 22 Jun 2017 13:14:42 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0MLRLO-1dNXRt21je-000gRt; Thu, 22 Jun 2017 19:14:07 +0200 From: Arnd Bergmann To: Andrew Morton Cc: kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Andrey Ryabinin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arend van Spriel , Arnd Bergmann , Masahiro Yamada , Michal Marek , Kees Cook , Ingo Molnar , "David S . Miller" , linux-kbuild@vger.kernel.org, Samuel Thibault , Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH v3 06/11] r820t: mark register functions as noinline_if_stackbloat Date: Thu, 22 Jun 2017 19:13:50 +0200 Message-Id: <20170622171355.267192-7-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170622171355.267192-1-arnd@arndb.de> References: <20170622171355.267192-1-arnd@arndb.de> X-Provags-ID: V03:K0:qv1cqBjhaf9wHHUE0q/VNqx8wJHVhVYY5AHiOhYuaEwxv22RIeP RITIVEuJt7pm6aUmL//LtkBEdJ6fOOKoIf+X/8uAtrSYiGv3+ykoLuP9YmkAbvmqBNZ90uS dFSdWuvkH5JAlOTy48y+FiW7t/h1CqDienD0jyy8TgdlkBEhAcgKGC4n14S60ah5EPRJANv sEcLv6q3NcICZtQgtOL2Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:/F4OELOyJVQ=:Z1PByIg/P+PqYNKOvPEDfw nveR0iLzLMHVGqSeKjx3+DneX7gDTRRVI+FEz9FMOCL2RPK9OeMOCtzHJQegAbF2tpfaqMbLe jn5cW9EDR0G7W3IGDmGbv9tRsmiGBEOkBkppk1BmXe73uO3DuF6toFezk8LTKSwl7nzf/fK2F wTDiiuID3aTjSW0ZmJxz/HeXe0/YvRWjocjb0dsNkSXUOmKVZn7NkEU2fLu70BvfLZnUJ6TgU NeOnMizN95d6ysg0c3KpCe4s9qVrw4SwJ8lbGtf24nyh8YfOQvaxXWKS2n6bs5bUW2QZtaHaO NPi9A+2wP33Ops2s4QUj0Hr0ZqpvCmcvn8Tpoe02WvBvjN+502A8HpUHnHxErfWp5mpa26f/7 +n2hK3xOz70hdNdxrBiSm6dtlgM7gXSPCaF1NdoRtamX0gxmELWy/pAhcxS+Y4Y9J7Zku51Un 0BzfifAFs3qhqgqlMu/k1qNatH9qY4ETIWg5S1FAvNhjTWOG11VSgWh2H9WGbw458VPFwjwdp bhwJt4Ap2qkPtXdDCZWcZ3SqNnxROaREmhAio1BRz252BpHJoGKywQzGnabt0naUdQXGrjBNq uS7gN90hX+jj6G1z25J0MgJ2cUIS8MCvUfQ7/OKQomc9KNJGF7U4HINukHPBrDTinn/i4a5iU qihb9zQ01ihoIj4ZBVZfZv/dAszs9pM4/jOFP1aLhSD55yYC3tK9ZVeU888TgUuD6NrU= Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With KASAN, we get an overly long stack frame due to inlining the register access function: drivers/media/tuners/r820t.c: In function 'generic_set_freq.isra.7': drivers/media/tuners/r820t.c:1334:1: error: the frame size of 2880 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] An earlier patch I tried used an open-coded r820t_write_reg() implementation that may have been more efficent, while this version simply adds the annotation, which has a lower risk for regressions. Signed-off-by: Arnd Bergmann --- drivers/media/tuners/r820t.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index ba80376a3b86..a26d0eb64555 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c @@ -396,7 +396,7 @@ static int r820t_write(struct r820t_priv *priv, u8 reg, const u8 *val, return 0; } -static int r820t_write_reg(struct r820t_priv *priv, u8 reg, u8 val) +static noinline_if_stackbloat int r820t_write_reg(struct r820t_priv *priv, u8 reg, u8 val) { return r820t_write(priv, reg, &val, 1); } @@ -411,7 +411,7 @@ static int r820t_read_cache_reg(struct r820t_priv *priv, int reg) return -EINVAL; } -static int r820t_write_reg_mask(struct r820t_priv *priv, u8 reg, u8 val, +static noinline_if_stackbloat int r820t_write_reg_mask(struct r820t_priv *priv, u8 reg, u8 val, u8 bit_mask) { int rc = r820t_read_cache_reg(priv, reg);