From patchwork Fri Jun 30 22:58:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9820629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 94CE7603F2 for ; Fri, 30 Jun 2017 22:58:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88250285D2 for ; Fri, 30 Jun 2017 22:58:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C3E3285E6; Fri, 30 Jun 2017 22:58:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2ED2F285D2 for ; Fri, 30 Jun 2017 22:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753090AbdF3W61 (ORCPT ); Fri, 30 Jun 2017 18:58:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51654 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbdF3W6Z (ORCPT ); Fri, 30 Jun 2017 18:58:25 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 18AA1607CE; Fri, 30 Jun 2017 22:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498863505; bh=dbP0wfl4eGg2hKqQXfOCb3aM1Pm9FDPbEKkH9uKt6oY=; h=From:To:Cc:Subject:Date:From; b=Thea4GdlYRn9Ym/fzqZ8d38YUs3qMU02r79KnXJx3nzO/pnn6/U/djmJlICSgq1oh hFHr/abjLbOG0lpr45Zw7Lz9Wkv3/mKaYiDCVpYJcypFMvpCRK3elIo11lMNDLSHGi oW4UguWXGhWLIviK8ctYrh8d0uTupBR9wU3IgppE= Received: from sboyd-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1DC6960727; Fri, 30 Jun 2017 22:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498863504; bh=dbP0wfl4eGg2hKqQXfOCb3aM1Pm9FDPbEKkH9uKt6oY=; h=From:To:Cc:Subject:Date:From; b=NBCxJS4AgTtfsKDIi+gc6lMUozjhShl67bW/IxQOFqTJ8iRDfYHkTVLrQo9xovDxu 5xZqSlAsibaS0sI3Lm+Zidg1Bod94M4OBUSQL1TXp50l07j3bb4BSNecKygZnMEbq0 auB7n5wXHycD1IG6YN6x5LyS5ry4v20ck4fhvLBA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1DC6960727 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org From: Stephen Boyd To: Masahiro Yamada , Michal Marek Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, Rob Clark , Bjorn Andersson Subject: [PATCH] kbuild: modpost: Warn about references from rodata to __init text Date: Fri, 30 Jun 2017 15:58:22 -0700 Message-Id: <20170630225822.25349-1-sboyd@codeaurora.org> X-Mailer: git-send-email 2.13.0.67.g10c78a162fa8 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If we have a structure that's marked const it will be placed into the .rodata section but it could reference an init section function. Include the read only data section in the check we have for read/write data sections referencing init sections so we can find this class of problems. This exposes quite a few places where const marked structures are referencing __init functions and __init data that we were previously ignoring. Cc: Rob Clark Cc: Bjorn Andersson Signed-off-by: Stephen Boyd --- Making this change leads to quite a few other errors even on the multi_v7_defconfig for ARM[1]. I still need to do a build of the allmodconfig to see how many other errors there, but it seems to be quite a few. I suppose those will need to be fixed before we can merge this? [1] https://www.irccloud.com/pastebin/zzqfWGQY/ scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 48397feb08fb..4f2be5c6727d 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -903,7 +903,7 @@ static void check_section(const char *modname, struct elf_info *elf, #define ALL_INIT_SECTIONS INIT_SECTIONS, ALL_XXXINIT_SECTIONS #define ALL_EXIT_SECTIONS EXIT_SECTIONS, ALL_XXXEXIT_SECTIONS -#define DATA_SECTIONS ".data", ".data.rel" +#define DATA_SECTIONS ".rodata", ".data", ".data.rel" #define TEXT_SECTIONS ".text", ".text.unlikely", ".sched.text", \ ".kprobes.text", ".cpuidle.text" #define OTHER_TEXT_SECTIONS ".ref.text", ".head.text", ".spinlock.text", \