diff mbox

Makefile: add targets for config-help and pkg-help

Message ID 20171017151848.3087-1-shuahkh@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shuah Khan Oct. 17, 2017, 3:18 p.m. UTC
Change to enable config help and package help from the main make level
to make it easier to use. It has become difficult to find config help
and pkg help specific output from the "help" information.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 Makefile | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Masahiro Yamada Oct. 18, 2017, 4:23 p.m. UTC | #1
2017-10-18 0:18 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
> Change to enable config help and package help from the main make level
> to make it easier to use. It has become difficult to find config help
> and pkg help specific output from the "help" information.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  Makefile | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 46bfb0ed2257..1d6f86df1b6c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1441,6 +1441,13 @@ help:
>         @echo  'Execute "make" or "make all" to build all targets marked with [*] '
>         @echo  'For further info see the ./README file'
>
> +PHONY += config-help
> +config-help:
> +       @$(MAKE) -f $(srctree)/scripts/kconfig/Makefile help
> +
> +PHONY += pkg-help
> +pkg-help:
> +       @$(MAKE) $(build)=$(package-dir) help
>
>  help-board-dirs := $(addprefix help-,$(board-dirs))
>
> --


What happened to "doc-help" ?
(I want to see consistent hyphenation)

Please follow Randy's suggestion.

Also you need to add %-help pattern to no-dot-config-targets.
Shuah Khan Oct. 18, 2017, 4:39 p.m. UTC | #2
On 10/18/2017 10:23 AM, Masahiro Yamada wrote:
> 2017-10-18 0:18 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>> Change to enable config help and package help from the main make level
>> to make it easier to use. It has become difficult to find config help
>> and pkg help specific output from the "help" information.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  Makefile | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 46bfb0ed2257..1d6f86df1b6c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1441,6 +1441,13 @@ help:
>>         @echo  'Execute "make" or "make all" to build all targets marked with [*] '
>>         @echo  'For further info see the ./README file'
>>
>> +PHONY += config-help
>> +config-help:
>> +       @$(MAKE) -f $(srctree)/scripts/kconfig/Makefile help
>> +
>> +PHONY += pkg-help
>> +pkg-help:
>> +       @$(MAKE) $(build)=$(package-dir) help
>>
>>  help-board-dirs := $(addprefix help-,$(board-dirs))
>>
>> --
> 
> 
> What happened to "doc-help" ?
> (I want to see consistent hyphenation)

I added doc-help to DOC_TARGETS directly. I should have done this
patch on top of the last one.

> 
> Please follow Randy's suggestion.

I will re-do this patch as per Randy's suggestions.
> 
> Also you need to add %-help pattern to no-dot-config-targets.
> 

Right. I will send v2 this week if possible. I have a couple of
trips coming up including the Kernel Summit.

thanks,
-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 46bfb0ed2257..1d6f86df1b6c 100644
--- a/Makefile
+++ b/Makefile
@@ -1441,6 +1441,13 @@  help:
 	@echo  'Execute "make" or "make all" to build all targets marked with [*] '
 	@echo  'For further info see the ./README file'
 
+PHONY += config-help
+config-help:
+	@$(MAKE) -f $(srctree)/scripts/kconfig/Makefile help
+
+PHONY += pkg-help
+pkg-help:
+	@$(MAKE) $(build)=$(package-dir) help
 
 help-board-dirs := $(addprefix help-,$(board-dirs))