From patchwork Fri Oct 20 21:09:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lin X-Patchwork-Id: 10020961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D421460234 for ; Fri, 20 Oct 2017 21:09:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C649F28F5E for ; Fri, 20 Oct 2017 21:09:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9E8B28F67; Fri, 20 Oct 2017 21:09:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2007628E82 for ; Fri, 20 Oct 2017 21:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbdJTVJU (ORCPT ); Fri, 20 Oct 2017 17:09:20 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:49172 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbdJTVJT (ORCPT ); Fri, 20 Oct 2017 17:09:19 -0400 Received: by mail-it0-f68.google.com with SMTP id y15so133751ita.4 for ; Fri, 20 Oct 2017 14:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ToCkQA9owT8ZCGo3DTK/bBglkLgTFzKL9fegEBp17i4=; b=XJ9U7NZDPyuTS5uywsK+p+xCImnLgZuHxCN593sUGfI2t18uTL8d9F7Tckx/WZ2czC viYe/PwzbRJjUZhtF86qh37M5rZjW3E2BLfBvj///Qayfgb4Lu5SYsYzAupk2paEAzMT 8nu0Dq98cf90S2CQWcacwQUPGGYpdw5qPXkhVX2aU9pamPE2XKf4von8nMIgBhc2f1Hk Lj5QcEK/kGOUjwBS5nIWwZZXN4a67S2n08aUlpCYJvsHuUGvGqR8iFL4sqLhNVF47Wzd q7Ycgq9mlxANuGopuxkam3yhw+zCnB2egabozpx7FX6UFVVsI+hcJ/uYGD1q0QCIU6yZ YU7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ToCkQA9owT8ZCGo3DTK/bBglkLgTFzKL9fegEBp17i4=; b=iGvkq97flSnX+u72cTi7wsojWHcSDTam7ETRXhnSgKI44iY1M3t4OI8bUozNwg8gRV SRbzFSk7otV8jDPsgFGN52Pem3xPRRVM8uFhvz6nqhvpWOeFtXDhRfOiQpD3P1oFGrfH I08RqXngd8pJ6IYJWQdIL/Rm9PjO8tn5RhHcHLnQcZPkhm4DtuiOWwHCsefLM19PUpCZ kWdpeuzb0rQN72i0+08I/aDhx7qZ+pTgXKizl7EsPj4leO1Qqy61+UTzzlPQ7WO96VLt 65ipSh6aVJWjVd2YCRKiqyCRKaql3N+lg9sRGpcVqf9o3260nRx5/mKmU23lZCq1udRg kDwA== X-Gm-Message-State: AMCzsaUKqPTI3Hdxjm9HU8DcvBDMraKzkJT4BJ3Yvu2ykxxY6CR0fmx5 INLFKzqGAc4gmYiOqzmOwYb12Q== X-Google-Smtp-Source: ABhQp+QvVqGHlJqNdLDrZqvcOgAASTvTZ0hxEsvYw/8chVC8lNAzWkgcksG4NCLoNu0fJi50eeIxQQ== X-Received: by 10.36.210.137 with SMTP id z131mr231710itf.41.1508533758437; Fri, 20 Oct 2017 14:09:18 -0700 (PDT) Received: from localhost ([2620:0:1000:1601:5999:a405:9af6:3b49]) by smtp.gmail.com with ESMTPSA id m12sm907829ita.10.2017.10.20.14.09.17 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 20 Oct 2017 14:09:17 -0700 (PDT) From: David Lin To: corbet@lwn.net, yamada.masahiro@socionext.com, michal.lkml@markovi.net, behanw@converseincode.com Cc: ghackmann@google.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, David Lin Subject: [PATCH] kbuild: clang: fix build failures with sparse check Date: Fri, 20 Oct 2017 14:09:13 -0700 Message-Id: <20171020210913.64498-1-dtwlin@google.com> X-Mailer: git-send-email 2.15.0.rc0.271.g36b669edcc-goog Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We should avoid using the space character when passing arguments to clang, because static code analysis check tool such as sparse may misinterpret the arguments followed by spaces as build targets hence cause the build to fail. Signed-off-by: David Lin --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 05f95df0a247..c8819d0de907 100644 --- a/Makefile +++ b/Makefile @@ -685,11 +685,11 @@ KBUILD_CFLAGS += $(stackp-flag) ifeq ($(cc-name),clang) ifneq ($(CROSS_COMPILE),) -CLANG_TARGET := -target $(notdir $(CROSS_COMPILE:%-=%)) +CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%)) GCC_TOOLCHAIN := $(realpath $(dir $(shell which $(LD)))/..) endif ifneq ($(GCC_TOOLCHAIN),) -CLANG_GCC_TC := -gcc-toolchain $(GCC_TOOLCHAIN) +CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN) endif KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)