diff mbox

[02/21] afs: Fix const confusion in AFS

Message ID 20171127213423.27218-3-andi@firstfloor.org (mailing list archive)
State New, archived
Headers show

Commit Message

Andi Kleen Nov. 27, 2017, 9:34 p.m. UTC 
From: Andi Kleen <ak@linux.intel.com>

A trace point string cannot be const because the underlying special
section is not marked const. An LTO build complains about the
section attribute mismatch. Fix it by not marking the trace point
string in afs const.

Cc: dhowells@redhat.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 fs/afs/cmservice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Howells Nov. 28, 2017, 4:04 p.m. UTC | #1 
Andi Kleen <andi@firstfloor.org> wrote:

> A trace point string cannot be const because the underlying special
> section is not marked const. An LTO build complains about the
> section attribute mismatch. Fix it by not marking the trace point
> string in afs const.

Do you want this to go through my tree?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andi Kleen Nov. 28, 2017, 4:50 p.m. UTC | #2 
On Tue, Nov 28, 2017 at 04:04:38PM +0000, David Howells wrote:
> Andi Kleen <andi@firstfloor.org> wrote:
> 
> > A trace point string cannot be const because the underlying special
> > section is not marked const. An LTO build complains about the
> > section attribute mismatch. Fix it by not marking the trace point
> > string in afs const.
> 
> Do you want this to go through my tree?

Yes please.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c
index 41e277f57b20..0e9ea0f8d620 100644
--- a/fs/afs/cmservice.c
+++ b/fs/afs/cmservice.c
@@ -31,7 +31,7 @@  static void SRXAFSCB_ProbeUuid(struct work_struct *);
 static void SRXAFSCB_TellMeAboutYourself(struct work_struct *);
 
 #define CM_NAME(name) \
-	const char afs_SRXCB##name##_name[] __tracepoint_string =	\
+	char afs_SRXCB##name##_name[] __tracepoint_string =	\
 		"CB." #name
 
 /*