diff mbox

[v2,6/7] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

Message ID 20171130233905.130602-7-samitolvanen@google.com
State New, archived
Headers show

Commit Message

Sami Tolvanen Nov. 30, 2017, 11:39 p.m. UTC
Some versions of GNU gold are known to produce broken code with
--fix-cortex-a53-843419 as explained in this bug:


If ARM64_ERRATUM_843419 is disabled and we're using GNU gold, pass
--no-fix-cortex-a53-843419 to the linker to ensure the erratum
fix is not used even if the linker is configured to enable it by

This change also adds a warning if the erratum fix is enabled and
gold version <1.14 is used.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
 arch/arm64/Makefile | 9 +++++++++
 1 file changed, 9 insertions(+)


Nick Desaulniers Dec. 1, 2017, 12:13 a.m. UTC | #1
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 82a0df6e865e..68eed687e468 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -26,8 +26,17 @@  ifeq ($(CONFIG_ARM64_ERRATUM_843419),y)
   ifeq ($(call ld-option, --fix-cortex-a53-843419),)
 $(warning ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum)
+    ifeq ($(call gold-ifversion, -lt, 114000000, y), y)
+$(warning This version of GNU gold may generate incorrect code with --fix-cortex-a53-843419;\
+	see https://sourceware.org/bugzilla/show_bug.cgi?id=21491)
+    endif
 LDFLAGS_vmlinux	+= --fix-cortex-a53-843419
+  ifeq ($(ld-name),gold)
+# Pass --no-fix-cortex-a53-843419 to ensure the erratum fix is disabled
+LDFLAGS	+= --no-fix-cortex-a53-843419
+  endif
 KBUILD_DEFCONFIG := defconfig