From patchwork Mon Jan 8 11:39:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 10149273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D9F58601BE for ; Mon, 8 Jan 2018 11:39:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C691728718 for ; Mon, 8 Jan 2018 11:39:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9FE528721; Mon, 8 Jan 2018 11:39:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E8ED28718 for ; Mon, 8 Jan 2018 11:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756044AbeAHLj3 (ORCPT ); Mon, 8 Jan 2018 06:39:29 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:43932 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756014AbeAHLj2 (ORCPT ); Mon, 8 Jan 2018 06:39:28 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.21) with SMTP id w08BahQR193025; Mon, 8 Jan 2018 11:39:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2017-10-26; bh=5C1DabSyCByaK0vdZ7qShizq8MQpJ1VSKg5P0l7xKfY=; b=q00TWObisCEx8HBBNo69QTJL1NYLGS2ppEfF45E8fuEdYMI610i/NE6wKJc4Scr4qFUs 1DEXEEDWyPrxE9lnkEFoJYQBGC/nESOII1Xf5dOoCoJnSjl7sO5EE+o5KWyZ8nGz6Wuy PuFDOQqli+QUv2cLioEMA9h/U8gCRYfiVqXrHnS77naAgLsVB4sX9C1AYe+FSZEfhRq+ LmwE0HkW8onPXyDzu41/qKGG3QWxlIHZRCjkmoWXlwZoVV6qngKAc63bzL42EV/u8A8e RiPziDTZapIL9kvAJtf7WOXkj86NDg+p3n0zrwEw+Kkcr+QOxoBY7OHxVVuXbeThxe0g tQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2fc5wrgjr3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2018 11:39:26 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w08BdP63017987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jan 2018 11:39:26 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w08BdPfG002327; Mon, 8 Jan 2018 11:39:25 GMT Received: from mwanda (/41.202.241.63) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Jan 2018 03:39:24 -0800 Date: Mon, 8 Jan 2018 14:39:12 +0300 From: Dan Carpenter To: Martin Kelly Cc: kernel-janitors@vger.kernel.org, Alexey Dobriyan , linux-kbuild@vger.kernel.org Subject: Re: [PATCH 1/1] tools: fix cross-compile var export Message-ID: <20180108113912.3eqyooxlpuqwr4zc@mwanda> References: <20171223210641.24588-1-martin@martingkelly.com> <20171223210641.24588-2-martin@martingkelly.com> <2512a330-1d30-d977-c635-233492da903a@martingkelly.com> <011d91f4-5410-eac4-ebbb-7777fbd6519a@martingkelly.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <011d91f4-5410-eac4-ebbb-7777fbd6519a@martingkelly.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8767 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=710 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801080169 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Jan 06, 2018 at 12:17:40PM -0800, Martin Kelly wrote: > On 12/23/2017 02:16 PM, Martin Kelly wrote: > > On 12/23/2017 01:06 PM, Martin Kelly wrote: > > > From: Martin Kelly > > > > > > Currently in a number of Makefiles, we clobber the CC, LD, and/or > > > STRIP env vars > > > when cross-compiling, which breaks any additional flags that might > > > be set (such > > > as sysroot). This easily shows up by using, for instance, a Yocto SDK. > > > > > > Fix this by more carefully overriding the flags in the way that the perf > > > Makefile does. > > > > > > This patch does not fix cross-compile for all the tools (some have > > > other bugs), > > > but it does appear to fix it for these: > > > > > > - cgroup > > > - freefall > > > - gpio > > > - hv > > > - iio > > > - leds > > > - spi > > > - vm > > > - wmi > > > > > > Signed-off-by: Martin Kelly > > > --- > > >   tools/cgroup/Makefile            |  1 - > > >   tools/gpio/Makefile              |  2 -- > > >   tools/hv/Makefile                |  1 - > > >   tools/iio/Makefile               |  2 -- > > >   tools/laptop/freefall/Makefile   |  1 - > > >   tools/leds/Makefile              |  1 - > > >   tools/perf/Makefile.perf         |  6 ------ > > >   tools/power/acpi/Makefile.config |  3 --- > > >   tools/scripts/Makefile.include   | 18 ++++++++++++++++++ > > >   tools/spi/Makefile               |  2 -- > > >   tools/usb/Makefile               |  1 - > > >   tools/vm/Makefile                |  1 - > > >   tools/wmi/Makefile               |  1 - > > >   13 files changed, 18 insertions(+), 22 deletions(-) > > > Hi Martin, This stuff needs to be broken up into one patch per directory and sent to the individual maintainers. Unfortunately, a lot of people haven't filled out MAINTAINERS properly for their tools/ directory so get_maintainer.pl doesn't always select the correct mailing list. Keeping track of the tools/ director is actually a good task for kernel-janitors btw. So you might need to manually check MAINTAINERS to find the correct list. regards, dan carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/MAINTAINERS b/MAINTAINERS index 042400542c55..14d93b30aeeb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3625,6 +3625,7 @@ S: Maintained F: Documentation/cgroup* F: include/linux/cgroup* F: kernel/cgroup* +F: tools/cgroup/ CONTROL GROUP - CPUSET M: Li Zefan