| Message ID | 20180205012146.23981-8-ulfalizer@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 > ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should > just be selected explicitly if needed. > > Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. > > See commit 0145071b3314 ("x86: Do away with > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > arch/riscv/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ff69c77b9e78..716e90e60e5c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -19,7 +19,6 @@ config RISCV > select GENERIC_STRNLEN_USER > select GENERIC_SMP_IDLE_THREAD > select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A > - select ARCH_WANT_OPTIONAL_GPIOLIB > select HAVE_MEMBLOCK > select HAVE_MEMBLOCK_NODE_MAP > select HAVE_DMA_API_DEBUG > -- > 2.14.1 > There's also a select of a globally undefined symbol RISCV_IRQ_INTC here. I couldn't dig up any historical or unmerged definition for it either. Googling just gets you the select. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 > ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should > just be selected explicitly if needed. > > Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. > > See commit 0145071b3314 ("x86: Do away with > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> This should probaly be replaced with select GPIOLIB Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > >> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >> just be selected explicitly if needed. >> >> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >> >> See commit 0145071b3314 ("x86: Do away with >> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >> >> Discovered with the >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > > This should probaly be replaced with > select GPIOLIB > > Yours, > Linus Walleij That'd make more sense if GPIOLIB is actually used. The select has been a no-op since mid-2016 at least, but maybe something else selects GPIOLIB. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 6, 2018 at 12:38 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: >> >>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >>> just be selected explicitly if needed. >>> >>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >>> >>> See commit 0145071b3314 ("x86: Do away with >>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >>> >>> Discovered with the >>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >>> script. >>> >>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >> >> This should probaly be replaced with >> select GPIOLIB >> >> Yours, >> Linus Walleij > > That'd make more sense if GPIOLIB is actually used. The select has > been a no-op since mid-2016 at least, but maybe something else selects > GPIOLIB. > > Cheers, > Ulf Just replace it with your own patch once you've figured out the proper fix. More efficient than having a middle man making (sometimes poor) guesses. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 > ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should > just be selected explicitly if needed. > > Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. > > See commit 0145071b3314 ("x86: Do away with > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> RISCV maintainers: please apply and carry this patch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 6, 2018 at 12:49 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > On Tue, Feb 6, 2018 at 12:38 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: >> On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >>> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: >>> >>>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >>>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >>>> just be selected explicitly if needed. >>>> >>>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >>>> >>>> See commit 0145071b3314 ("x86: Do away with >>>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >>>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >>>> >>>> Discovered with the >>>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >>>> script. >>>> >>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >>> >>> This should probaly be replaced with >>> select GPIOLIB >>> >>> Yours, >>> Linus Walleij >> >> That'd make more sense if GPIOLIB is actually used. The select has >> been a no-op since mid-2016 at least, but maybe something else selects >> GPIOLIB. >> >> Cheers, >> Ulf > > Just replace it with your own patch once you've figured out the proper > fix. More efficient than having a middle man making (sometimes poor) > guesses. I think it's just a side effect of the new RISCV arch being developed outside of the mainline kernel. And they may have had a gpio driver outside of the mainline as well. Normally we don't encourage out-of-tree development, but new archs are a bit of an exception since they have to be merged as a big piece of upfront code at some point... Anyways, if they don't have any GPIO in their machine yet, let's let the RISCV maintainers apply this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 04 Feb 2018 17:21:19 PST (-0800), ulfalizer@gmail.com wrote: > The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 > ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should > just be selected explicitly if needed. > > Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. > > See commit 0145071b3314 ("x86: Do away with > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > arch/riscv/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ff69c77b9e78..716e90e60e5c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -19,7 +19,6 @@ config RISCV > select GENERIC_STRNLEN_USER > select GENERIC_SMP_IDLE_THREAD > select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A > - select ARCH_WANT_OPTIONAL_GPIOLIB > select HAVE_MEMBLOCK > select HAVE_MEMBLOCK_NODE_MAP > select HAVE_DMA_API_DEBUG Thanks! (If you want these through my tree, just say something.) Reviewed-by: Palmer Dabbelt <palmer@sifive.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 04 Feb 2018 17:30:57 PST (-0800), ulfalizer@gmail.com wrote: > On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: >> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >> just be selected explicitly if needed. >> >> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >> >> See commit 0145071b3314 ("x86: Do away with >> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >> >> Discovered with the >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >> --- >> arch/riscv/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig >> index ff69c77b9e78..716e90e60e5c 100644 >> --- a/arch/riscv/Kconfig >> +++ b/arch/riscv/Kconfig >> @@ -19,7 +19,6 @@ config RISCV >> select GENERIC_STRNLEN_USER >> select GENERIC_SMP_IDLE_THREAD >> select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A >> - select ARCH_WANT_OPTIONAL_GPIOLIB >> select HAVE_MEMBLOCK >> select HAVE_MEMBLOCK_NODE_MAP >> select HAVE_DMA_API_DEBUG >> -- >> 2.14.1 >> > > There's also a select of a globally undefined symbol RISCV_IRQ_INTC > here. I couldn't dig up any historical or unmerged definition for it > either. Googling just gets you the select. It looks like this slipped through, the symbol has been renamed RISCV_INTC. A patch to remove it is Reviewed-by: Palmer Dabbelt <palmer@sifive.com> (and like the other ones, if you want it through my tree just say something) -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 08, 2018 at 10:34:19AM -0800, Palmer Dabbelt wrote: > On Sun, 04 Feb 2018 17:21:19 PST (-0800), ulfalizer@gmail.com wrote: > > The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 > > ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should > > just be selected explicitly if needed. > > > > Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. > > > > See commit 0145071b3314 ("x86: Do away with > > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do > > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > > > Discovered with the > > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > > script. > > > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > > --- > > arch/riscv/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index ff69c77b9e78..716e90e60e5c 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -19,7 +19,6 @@ config RISCV > > select GENERIC_STRNLEN_USER > > select GENERIC_SMP_IDLE_THREAD > > select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A > > - select ARCH_WANT_OPTIONAL_GPIOLIB > > select HAVE_MEMBLOCK > > select HAVE_MEMBLOCK_NODE_MAP > > select HAVE_DMA_API_DEBUG > > Thanks! > > (If you want these through my tree, just say something.) I didn't have a particular tree in mind for these patches, so feel free to take it. > > Reviewed-by: Palmer Dabbelt <palmer@sifive.com> Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 06 Feb 2018 01:47:00 PST (-0800), linus.walleij@linaro.org wrote: > On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > >> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >> just be selected explicitly if needed. >> >> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >> >> See commit 0145071b3314 ("x86: Do away with >> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >> >> Discovered with the >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > RISCV maintainers: please apply and carry this patch. OK, I'll atke it into my tree. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index ff69c77b9e78..716e90e60e5c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -19,7 +19,6 @@ config RISCV select GENERIC_STRNLEN_USER select GENERIC_SMP_IDLE_THREAD select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A - select ARCH_WANT_OPTIONAL_GPIOLIB select HAVE_MEMBLOCK select HAVE_MEMBLOCK_NODE_MAP select HAVE_DMA_API_DEBUG
The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should just be selected explicitly if needed. Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. See commit 0145071b3314 ("x86: Do away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- arch/riscv/Kconfig | 1 - 1 file changed, 1 deletion(-)