From patchwork Fri Feb 16 20:22:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Magnusson X-Patchwork-Id: 10225605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D5D8602CB for ; Fri, 16 Feb 2018 20:24:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D0EE295DB for ; Fri, 16 Feb 2018 20:24:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00F51295DD; Fri, 16 Feb 2018 20:24:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 927C7295DA for ; Fri, 16 Feb 2018 20:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750848AbeBPUXc (ORCPT ); Fri, 16 Feb 2018 15:23:32 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:44538 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbeBPUXa (ORCPT ); Fri, 16 Feb 2018 15:23:30 -0500 Received: by mail-lf0-f67.google.com with SMTP id v9so3632438lfa.11; Fri, 16 Feb 2018 12:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/uPVngIxH66i8kYHwZzqEsOnG3ZSsK9bgaMcLyUmCKQ=; b=ve+FL5eghVrEofHHroypn7pMy/kyJy3JLuInd+gK+vPe9p4pc2+WWpwqwZxICWR2TA 5cdWrespQu2Jj4r+Lp0L6yPSAmGkCywu3mUfwDH8YsSB1uv/z4fxO3++DJ1+d4HyjndH gNCeP5bdjjTkhiXXd/K3DYW16ZcjSpi9NOrjyJSq3DtxvCHPmPNrhhpAo4kBJwwPyc0v CFbo6tIbu39qvmz2f3J+Gf+VdiGcps+TFo+ae0VsvT0XzbWFsaNUoigzNNqMyts4ae6K j/gD4Qa8+cjql8tKGj9PhQ46c8Dvq1ZSz5dlw0J/+kWILlwZS0Jtf9IVMDwFlnkk38g+ KuMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/uPVngIxH66i8kYHwZzqEsOnG3ZSsK9bgaMcLyUmCKQ=; b=G+GdIKzavdmaf87QEpRfEAdT4AIrtxikbdKAvUWDMlZOhwEWBffyveiADjkqNcX/+k ZSKpwCrKtH6EFhmeZ1VJDEFlZNd6URymGIAx+0L31ylcTQL2XSxLbxqHXG6/JT0vHcCv Ts4iIc1V+5rcZ1EoTnb8xYnJVfGA23GjYHlae/vSgWoNmkE6r68ewpvSzVhDwa+E59GS p7Y7gxEDwJdC/N0/rJbCrMkZTeCa5GcSaA7MOIKu087Bwqa3fWFEGRISra7FtM/UE0O9 C1Vf4EJ+str8dBRK3bmaf4XZLWWUuyjtQRD6mHOuCpi1nnLjsiQx7f2QWE13CC25RNYf Jv4A== X-Gm-Message-State: APf1xPBPQOcogbRW+al+GKIKzXhQNDT9DzDBXY41huB8aXYRM84A+I00 3OiSle+Jr8Am6vYacJEi9XU= X-Google-Smtp-Source: AH8x2253f9tfxe+SxNZDntEXye8UkizTucJonzh8bt0dmBFe9D18pMS8DvtSkpTgPoe7B1JytSNL4Q== X-Received: by 10.46.20.67 with SMTP id 3mr1850189lju.104.1518812608454; Fri, 16 Feb 2018 12:23:28 -0800 (PST) Received: from huvuddator.lan (ua-213-113-106-221.cust.bredbandsbolaget.se. [213.113.106.221]) by smtp.gmail.com with ESMTPSA id y7sm1652539ljd.45.2018.02.16.12.23.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2018 12:23:28 -0800 (PST) From: Ulf Magnusson To: apw@canonical.com, joe@perches.com Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Ulf Magnusson Subject: [PATCH 1/3] checkpatch: kconfig: recognize more prompts when checking help texts Date: Fri, 16 Feb 2018 21:22:53 +0100 Message-Id: <20180216202255.25307-2-ulfalizer@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180216202255.25307-1-ulfalizer@gmail.com> References: <20180216202255.25307-1-ulfalizer@gmail.com> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The check for a missing or short help text only considers symbols with a prompt, but doesn't recognize any of the following as a prompt: bool 'foo' tristate 'foo' prompt "foo" prompt 'foo' Make the check recognize those too. Signed-off-by: Ulf Magnusson --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3d4040322ae1..2b404317daea 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2812,7 +2812,7 @@ sub process { next if ($f =~ /^-/); last if (!$file && $f =~ /^\@\@/); - if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) { + if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) { $is_start = 1; } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) { $length = -1;