| Message ID | 20180322210525.25361-1-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2018-03-23 6:05 GMT+09:00 Rasmus Villemoes <linux@rasmusvillemoes.dk>: > Commit (7840fea200cd "kbuild: Fix computing srcversion for modules") > fixed the comment above parse_source_files to refer to the new source_ > line, but left this one behind that could still give the impression that > drivers/net/dummy.c appears in the deps_ variable. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > Resending because I didn't reach any current kbuild maintainers nor > the kbuild mailing list. > > scripts/mod/sumversion.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c > index 944418da9fe3..0f6dcb4011a8 100644 > --- a/scripts/mod/sumversion.c > +++ b/scripts/mod/sumversion.c > @@ -330,14 +330,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md) > goto out; > } > > - /* There will be a line like so: > - deps_drivers/net/dummy.o := \ > - drivers/net/dummy.c \ > - $(wildcard include/config/net/fastroute.h) \ > - include/linux/module.h \ > - > - Sum all files in the same dir or subdirs. > - */ > + /* Sum all files in the same dir or subdirs. */ > while ((line = get_next_line(&pos, file, flen)) != NULL) { > char* p = line; > > -- > 2.15.1 > Applied to linux-kbuild/fixes. Thanks!
diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c index 944418da9fe3..0f6dcb4011a8 100644 --- a/scripts/mod/sumversion.c +++ b/scripts/mod/sumversion.c @@ -330,14 +330,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md) goto out; } - /* There will be a line like so: - deps_drivers/net/dummy.o := \ - drivers/net/dummy.c \ - $(wildcard include/config/net/fastroute.h) \ - include/linux/module.h \ - - Sum all files in the same dir or subdirs. - */ + /* Sum all files in the same dir or subdirs. */ while ((line = get_next_line(&pos, file, flen)) != NULL) { char* p = line;
Commit (7840fea200cd "kbuild: Fix computing srcversion for modules") fixed the comment above parse_source_files to refer to the new source_ line, but left this one behind that could still give the impression that drivers/net/dummy.c appears in the deps_ variable. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- Resending because I didn't reach any current kbuild maintainers nor the kbuild mailing list. scripts/mod/sumversion.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)