From patchwork Thu Mar 22 21:05:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 10302319 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C498660216 for ; Thu, 22 Mar 2018 21:05:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B6291289E9 for ; Thu, 22 Mar 2018 21:05:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA626289EE; Thu, 22 Mar 2018 21:05:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 379D3289E9 for ; Thu, 22 Mar 2018 21:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbeCVVF3 (ORCPT ); Thu, 22 Mar 2018 17:05:29 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:40540 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbeCVVF3 (ORCPT ); Thu, 22 Mar 2018 17:05:29 -0400 Received: by mail-wm0-f67.google.com with SMTP id t6so40785wmt.5 for ; Thu, 22 Mar 2018 14:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AZGrp1wdFyfYBgqXjdWrxClw1ycM7wn+XY8i3ZZSlmI=; b=fZqkx+r63QCxM4QVtHEFdridiskgkIHw9gh4jvRePnC0dK9iIwrQ3v2cjel5eyVf4K buZ+XNIZJED4Tjhe7cRTm37rGSgZJHpxgcHp3jIzrwDWXs//keHj6vYvnDkQE2ufXAy+ JDoHxcDeCYU8izvmZ0UVTlYsCIuQZnaKx4rVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AZGrp1wdFyfYBgqXjdWrxClw1ycM7wn+XY8i3ZZSlmI=; b=kKV6Dy/hNwh00jXy2pYOJgJ5Rdkpnda8EM6Im+RisQTTDHnyHwnpMCpmGAfRfHwZ1l cXYGaw0xowZE1MGh2t/xduHg3MVeGuqrAm/8Y3XNvrFgx+Oh/Nvge4qJrv2hDgrwrUKt k5Zkn/Wt174Obs7ROIRUE+SnRXLS1aFQFjtd7YCs0LDqlF/w9ICRo/3CXUHyUW8lWkpi 2s4XQnMRphQ5xJhAP3prupRXDcgWEepdUi41mzId8EF5gyRfrz1gFSA0rOYI/XF6Za08 GajyNh+DROoX2MVYwmZ3WhQ7od0KNh/+6EbSImzABNfidzqecuTcxPpOgnp6niW0SNF9 sPKQ== X-Gm-Message-State: AElRT7FitK/et686NxQkXao20jzE0LM07BPYFwFOUrMOMX05U92G+HEC XKdAUQtJHsd36mSCpZ2V0jg7BQ== X-Google-Smtp-Source: AG47ELuRPWf2ULphzIRQ1o337O+lM1B9wzeyv8NEsyXJ1IrSsdnQBSrVhh+SM57ocLfzzCoR6IxEcg== X-Received: by 10.80.195.66 with SMTP id q2mr19298752edb.254.1521752727930; Thu, 22 Mar 2018 14:05:27 -0700 (PDT) Received: from prevas-ravi.waoo.dk (dhcp-5-186-126-104.cgn.ip.fibianet.dk. [5.186.126.104]) by smtp.gmail.com with ESMTPSA id w1sm5315169edk.82.2018.03.22.14.05.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 22 Mar 2018 14:05:27 -0700 (PDT) From: Rasmus Villemoes To: Masahiro Yamada , Michal Marek Cc: Rusty Russell , Sam Ravnborg , Rasmus Villemoes , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC resend 1/2] modpost: delete stale comment Date: Thu, 22 Mar 2018 22:05:23 +0100 Message-Id: <20180322210525.25361-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180322150005.15061-2-linux@rasmusvillemoes.dk> References: <20180322150005.15061-2-linux@rasmusvillemoes.dk> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit (7840fea200cd "kbuild: Fix computing srcversion for modules") fixed the comment above parse_source_files to refer to the new source_ line, but left this one behind that could still give the impression that drivers/net/dummy.c appears in the deps_ variable. Signed-off-by: Rasmus Villemoes --- Resending because I didn't reach any current kbuild maintainers nor the kbuild mailing list. scripts/mod/sumversion.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c index 944418da9fe3..0f6dcb4011a8 100644 --- a/scripts/mod/sumversion.c +++ b/scripts/mod/sumversion.c @@ -330,14 +330,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md) goto out; } - /* There will be a line like so: - deps_drivers/net/dummy.o := \ - drivers/net/dummy.c \ - $(wildcard include/config/net/fastroute.h) \ - include/linux/module.h \ - - Sum all files in the same dir or subdirs. - */ + /* Sum all files in the same dir or subdirs. */ while ((line = get_next_line(&pos, file, flen)) != NULL) { char* p = line;